1310668 - Stats calculations are off

Status: RESOLVED MOVED

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[Matjaz Horvat [:mathjazz]]

Stats do not always reflect the actual state.

Multiple inconsistencies occur in the data model from time to time. Here's more specifics for developers:
1. TranslatedResource: translated + suggested + fuzzy > total
2. TranslatedResource & Resource: total_strings missmatch
3. ProjectLocale within the same project: total missmatch

Comment 3

[Matjaz Horvat [:mathjazz]]

Possibly the most common reason for stats discrepancies currently is caused by duplicate approved translations submitted for the same string within a locale. It shouldn't be to hard to fix this when counting stats, but we should prevent duplicate submissions in first place.

Comment 5

[Théo Chevalier]

Commenting here, because I think I’m seeing something related, but different from the temporary stats issue that is solved at next sync.

Thunderbird is displayed as 100% - 0 missing strings, several days after strings have landed: https://pontoon.mozilla.org/fr/thunderbird/ while we can see the strings here https://pontoon.mozilla.org/fr/thunderbird/all-resources/?status=missing

If people are not paying attention to Elmo (which is the case…), they could theoretically miss deadlines.

Comment 6

[Matjaz Horvat [:mathjazz]]

Thanks for reporting, Théo!

This type of error seems to be the subset of type #1 mentioned above. When translated strings are removed, we fail to reduce the number of translated strings in stats - and as a consequence, we also fail to increase the number of missing strings. In this subset case, the number of added and removed strings is the same, so we should 0 missing strings if the file was previously translated.

I've found two occurences:
https://hg.mozilla.org/users/m_owca.info/thunderbird-central/rev/318639affa08
https://hg.mozilla.org/users/m_owca.info/firefox-central/diff/37193f8be622/devtools/client/aboutdebugging.properties

For now, I've fixed stats by running calculate_stats() for all of the affected files for all locales.

I'm taking this bug now, because as you mentioned, it could have quite critical implications.

Comment 7

[Matjaz Horvat [:mathjazz]]

An observation for projects with in-context l10n: stats for the Subpage can be OK, while stats for ProjectLocale aren't.

Such situations (along with some other mentioned above) are likely to get fixed on the following sync.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/747d91a40201f217eea401b7612d9fc8c1ea7650
Bug 1310668: Recalculate stats when sync completes (#621)

Comment 9

[Matjaz Horvat [:mathjazz]]

This ^^ works well for now, but is obviously just a temporary fix.

Comment 10

[BMO Automation]

*This bug has been moved to GitHub.*

*Please check it out on https://github.com/mozilla/pontoon/issues.*