1310957 - Image preview tooltip remains visible when window loses focus

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Julian Descottes [:jdescottes]]

Attachment: image-preview-on-other-window.gif

Regression from Bug 1301342.

Now that the XUL panel used by the HTMLTooltips has the "noautohide" attribute set to true, the tooltips are no longer hidden when the window loses focus (see attached GIF)

This is only an issue for tooltips using a XULPanelWrapper because the other tooltips are constrained to the devtools document and can't be displayed outside of the devtools' window. 

We should try an alternative solution for 1301342 and reuse the fact that XUL panels get automatically hidden rather than preventing it. For instance we could listen for the "hidden" event of the panel, and programmatically hide the corresponding HTMLTooltip when we receive it.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1310957 - listen to XUL Panel wrapper hidden event to hide HTML tooltip;

Review commit: https://reviewboard.mozilla.org/r/86742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86742/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8802326 [details]
Bug 1310957 - listen to XUL Panel wrapper hidden event to hide HTML tooltip;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86742/diff/1-2/

Comment 3

[Julian Descottes [:jdescottes]]

Implemented the approach described in the summary. Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=d98e767c662805160a39652ccfca2096cd6f3d57

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8802326 [details]
Bug 1310957 - listen to XUL Panel wrapper hidden event to hide HTML tooltip;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86742/diff/2-3/

Comment 5

[Julian Descottes [:jdescottes]]

Try is green except for unrelated taskcluster issues. Asking for review!

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 8802326 [details]
Bug 1310957 - listen to XUL Panel wrapper hidden event to hide HTML tooltip;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86742/diff/3-4/

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8802326 [details]
Bug 1310957 - listen to XUL Panel wrapper hidden event to hide HTML tooltip;

https://reviewboard.mozilla.org/r/86742/#review85966

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ee4fd380512
listen to XUL Panel wrapper hidden event to hide HTML tooltip;r=gl

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9ee4fd380512

Comment 10

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 52.0a1 (2016-10-18) (64-bit) on Windows 7, 64 Bit !

This bug's fix is verified with latest Nightly 

Build ID     20161028030204
User Agent   Mozilla/5.0(Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0

Comment 11

[Petruta Horea [:phorea], Desktop QA]

Thanks for verifying using Windows :mMARUF!

Also confirmed verified fixed under Mac OS X 10.11 with latest Nightly 52.0a1, so I'm updating it's resolution.