1311116 - Reduce the default output from the marionette instance in debug builds

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Josh Matthews [:jdm]]

As a user of debug builds to run tests, the output from the marionette client isn't useful to me, but there's a lot of it and it's on by default: https://dxr.mozilla.org/mozilla-central/rev/dc89484d4b45abf442162e5ea2dd46f9de40197d/testing/marionette/components/marionettecomponent.js#70 . Could we reverse this, so that the developers that care about the marionette debug output could enable a preference instead?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Usually you can specify -vv on the command line to enable tracing output for Marionette. I think we had it enabled by default for debug builds in early stages of Marionette for a better debugging experience.

Andreas implemented that and I would give him the word here...

Comment 2

[Andreas Tolfsen ❲:ato❳]

I think I’m fine with raising the default logging level of debug builds to Log.Level.Info.  We can configure the try jobs, if we decide we need it in the future, to use Log.Level.Debug by setting the marionette.logging preference to "debug".

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1311116 - Use info level logging in Marionette debug builds;

Increase the default logging level for debug builds to `Log.Level.Info`.
If we desire a finer log level for debug builds on try jobs, we can
set the `marionette.logging` preference from the Marionette client in
the future.

Review commit: https://reviewboard.mozilla.org/r/92028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92028/

Comment 4

[David Burns :automatedtester]

Comment on attachment 8809434 [details]
Bug 1311116 - Use info level logging in Marionette debug builds;

https://reviewboard.mozilla.org/r/92028/#review92280

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

FYI the tracing output of Marionette was totally helpful for me in the last couple of weeks to actually nail down intermittent failures on autoland and m-c. Especially those which do not appear that often. Seeing now that all the output will go away will make it certainly harder to find the root cause.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Josh, was your request more for local builds or also related to results on Treeherder? If it's only for local we should fix our command line for Taskcluster and buildbot and get -vv added.

Comment 7

[Josh Matthews [:jdm]]

Local builds.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, that sounds fine. Andreas, I would suggest that at the same time we should get this option added to mozharness builds so that we can keep tracing enabled for now, which is very helpful as mentioned above.

Comment 9

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #8)
> Ok, that sounds fine. Andreas, I would suggest that at the same time we
> should get this option added to mozharness builds so that we can keep
> tracing enabled for now, which is very helpful as mentioned above.

Yes.  Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1317330.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c001b02b278
Use info level logging in Marionette debug builds; r=automatedtester

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1c001b02b278

Comment 12

[James Graham [:jgraham]]

Attachment: 1311116-aurora.diff

Attached a version of the patch suitable for uplift to aurora. Try run at [1]. (Assuming the try run agrees) this fixes bug 1273470 on aurora.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=59b6bda4fa1e108e9b30f4d545b0014de87473ee

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8826605 [details] [diff] [review]
1311116-aurora.diff

I don't have issues grafting the original changeset to aurora. So this additional patch is not necessary.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please uplift this test-only patch to aurora. Thanks.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c3f395000af7