1311472 - [tracking] mozillaonline addons/firefox CN distribution

Status: NEW

(WebExtensions :: General, defect, P3)

Description

[Shane Caraveo (:mixedpuppy)]

MozillaOnline (CN distribution) includes a number of addons by default.

[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]

Comment 1

[Shane Caraveo (:mixedpuppy)]

Issues encountered during conversion of easyscreenshot [I'll have to see if solutions or bugs exist for any of these]

1. We lose the ability to style the navbar button to make it consistent
   with browser; Bug 1207597 ?
2. We can't use the same button id for it to stay where it was (navbar, 
   menu panel, customization palette);
3. We lose the ability to communicate with other extensions, e.g.
   cpmanager, our main extension;
4. We now have to use the scroll and capture approach for the full page
   screenshot, which takes longer than the "old" drawWindow call and
   involves handling fixed positioned element in the page; Bug 1310318
5. I have not been able to figure out how to copy the edited screenshot 
   into the clipboard in an extension page, the selection/execCommand combo
   doesn't seem to work for any thing but text;
6. It's not possible to let user customize the WebExtensions defined
   shortcuts;
7. No visual clue when a badged navbar button (all WebExtensions ones)
   is disabled. Bug 1204609

Comment 2

[Hector Zhao [:hectorz]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #1)
> 
> 1. We lose the ability to style the navbar button to make it consistent
>    with browser; Bug 1207597 ?

Yes, we were trying to match all the variants of Fx toolbar styles[1]: inverted, hi-dpi, different versions of macOS or Windows. Bug 1207597 sounds like helpful.

> 3. We lose the ability to communicate with other extensions, e.g.
>    cpmanager, our main extension;

We have an unified on/off switch inside cpmanager to control tracking pings we send from other extensions. This used to be a `try { Cu.import(...) ... } catch(ex) { ... }`, maybe bug 1258360 would be helpful here.

> 6. It's not possible to let user customize the WebExtensions defined
>    shortcuts;

See [2], "If a key combination is already used by the browser (for example, "Ctrl+Shift+R"), or by an existing add-on, then you can't override it. You will be allowed to define it, but your event handler will not be called when the user enters it." We used to make the shortcuts customizable for this, but it's no longer possible with the `commands` JavaScript API[3].

[1]: https://dxr.mozilla.org/mozilla-central/search?q=path%3Abrowser%2Fthemes+path%3AToolbar+-path%3Aplaces+ext%3Apng
[2]: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/commands#Key_combinations
[3]: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/commands

Comment 3

[Hector Zhao [:hectorz]]

Recently, we at Beijing office did a preliminary classification of current features of our extensions.

I'll file bugs for the potential API gaps we identified blocking this one.

For each of the features, we might need a new API created (or better, one already planned or exists but I'm not aware of it) or maybe it's better to upstream the work into the vanilla Firefox.

Comment 4

[Hector Zhao [:hectorz]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #1)
> 5. I have not been able to figure out how to copy the edited screenshot 
>    into the clipboard in an extension page, the selection/execCommand combo
>    doesn't seem to work for any thing but text;

Bug 1325759

Comment 5

[Hector Zhao [:hectorz]]

TCPSocket will be necessary for our Email notifier extension which has a very minimal implementation of IMAP.

Comment 6

[Hector Zhao [:hectorz]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> [e-mail]

Possible API for this one.

Comment 7

[Hector Zhao [:hectorz]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> [e-mail]

Double click a tab to close it.
Open bookmarks/search results in new tab when the current tab is not blank

Comment 8

[Hector Zhao [:hectorz]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> [e-mail]

Alternative new tab page, and its access to thumbnailing service
Load a webpage into a browser inside about:cehome (may not be necessary per bug 1322304 comment 6) and use it as homepage
Updates to partner bookmarks, based on the predefined keywords in distribution.ini

Comment 9

[Hector Zhao [:hectorz]]

A few APIs we're interested in but not specific to one extension.

Comment 10

[Hector Zhao [:hectorz]]

(In reply to Hector Zhao [:hectorz] from comment #9)
> A few APIs we're interested in but not specific to one extension.

Bug 1253419 is necessary for the restore recently closed tabs button: we need the main button to restore the most recent one and the secondary dropdown to list more.

Comment 11

[Hector Zhao [:hectorz]]

Necessary for opening a link with drag-n-drop.

Comment 12

[YF (Yang)]

(In reply to Hector Zhao [:hectorz] from comment #11)
> Necessary for opening a link with drag-n-drop.

Really? browser.tabs.create with index. FYI: https://github.com/harytfw/GlitterDrag

Comment 13

[Hector Zhao [:hectorz]]

(In reply to YF (Yang) from comment #12)
> 
> Really? browser.tabs.create with index. FYI:
> https://github.com/harytfw/GlitterDrag

Ah, maybe I should say "properly". Yes, you could calculate an index to position the new tab, but Fx won't know it's opened by following a link in another page.

Comment 14

[Hector Zhao [:hectorz]]

With regards to search engines， we would like to be able to initiate a search with the current selected engine (like when user select some non-url text and then drag it).

Comment 15

[Firefox Bug Husbandry Bot]

Bulk move of bugs per https://bugzilla.mozilla.org/show_bug.cgi?id=1483958