1311898 - Night mode increases brightness level if it's already low

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P3)

Description

[Bunn [:bunn]]

Attachment: nightmode.mov

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160916101415

Steps to reproduce:

1 - Set the brightness level of your device to the lowest setting;
2 - Open Firefox settings;
3 - Select Night Mode;



Actual results:

- The brightness level of my device was increased;


Expected results:

- Night mode should *not* increase the brightness level at any circumstance. 
Proposed solution:
- If the brightness level is higher than the one set by night mode. Set night mode default level;
- If the brightness level is lower than the one set by night mode. Set night mode level to same level as the device.

(The video recorded does not display the brightness difference on the screen since it's recorded using quicktime, but it's possible to notice the difference on the brightness settings on iOS control center)

Comment 1

[lyang]

Attachment: pull request

Comment 2

[Stephan Leroux [:sleroux]]

Comment on attachment 8827015 [details] [review]
pull request

LGTM - just a code nit.

Comment 3

[lyang]

Comment on attachment 8827015 [details] [review]
pull request

Update

Comment 4

[Stephan Leroux [:sleroux]]

LGTM - Thanks!

master https://github.com/mozilla-mobile/firefox-ios/commit/0786eeac4055409556ecc62041f553d263c6b931

Comment 5

[Simon Basca [:SimonB]]

Verifying as fix on master 51abcc7c. 


Night mode should no longer increases the brightness level.