Closed Bug 1312683 Opened 8 years ago Closed 8 years ago

[e10s] Increased number of hangs in navigate() since patches from bug 1198381 have landed

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox51 unaffected, firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox51 --- unaffected
firefox52 --- fixed

People

(Reporter: whimboo, Unassigned)

References

(
URL
)

Details

(Keywords: regression) 

Investigation on bug 1312633 has been shown that we have an increased number of hangs in our Marionette tests since yesterday. When I had a look at Treeherder it looks like that with the push of the patches on bug 1198381 it got worse.

So we see dead locks for threads like:

1477358366605	Marionette	TRACE	conn383 -> [0,5,"get",{"url":"http://127.0.0.1:49334/javascriptPage.html"}]
--DOMWINDOW == 43 (11D5C400) [pid = 988] [serial = 78] [outer = 00000000] [url = about:blank]
[Child 3760] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file c:/builds/moz2_slave/autoland-w32-d-000000000000000/build/src/toolkit/xre/nsXREDirProvider.cpp, line 1703
[Child 3760] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file c:/builds/moz2_slave/autoland-w32-d-000000000000000/build/src/xpcom/base/nsSystemInfo.cpp, line 116
++DOCSHELL 09F2E800 == 1 [pid = 3760] [id = 1]
++DOMWINDOW == 1 (09F2F000) [pid = 3760] [serial = 1] [outer = 00000000]
++DOMWINDOW == 2 (0ADDA400) [pid = 3760] [serial = 2] [outer = 09F2F000]
[Child 3760] WARNING: site security information will not be persisted: file c:/builds/moz2_slave/autoland-w32-d-000000000000000/build/src/security/manager/ssl/nsSiteSecurityService.cpp, line 268
###!!! ERROR: Potential deadlock detected:
=== Cyclical dependency starts at
--- Mutex : nsThread.mLock (currently acquired)
 calling context
  [stack trace unavailable]

--- Next dependency:
--- Mutex : mozilla.ipc.MessageChannel.mMonitor (currently acquired)
 calling context
  [stack trace unavailable]

=== Cycle completed at
--- Mutex : nsThread.mLock (currently acquired)
 calling context
  [stack trace unavailable]

###!!! Deadlock may happen NOW!


The patch on bug 1198381 has been made some changes to handling of threads. So Andreas, can you please check if that could be the cause? Thanks.
Blocks: 1312633
setting n-i for andreas
Flags: needinfo?(afarre)
Comparing different branches (mozilla-central, autoland, mozilla-inbound, and fx-team) they seem to all show a similar behavior. Whereby for some the changes haven't been tested yet, so the Mn-e10s jobs are still green. We will know more soon.

Carsten backed out the patch on mozilla-central and will merge it around for other integration branches. So shall we keep this bug open or close it given that the offending patch is no longer present?
Blocks: 1198381
Keywords: regressionwindow-wanted
Whiteboard: [regression from bug 1198381?]
If we can see that the erroneous behaviour disappears then we can close it, and I'll keep it in mind when fixing 1198381 instead.
Flags: needinfo?(afarre)
All newer landed changesets have passing Mn-e10s tests for Windows 7 VM debug. So the backout on bug  1312683 actually fixed his problem.
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51: --- → unaffected
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
(In reply to Henrik Skupin (:whimboo) from comment #5)
> All newer landed changesets have passing Mn-e10s tests for Windows 7 VM
> debug. So the backout on bug  1312683 actually fixed his problem.

Well, I meant bug 1198381.
No longer blocks: 1312624
No longer blocks: 1312629
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.