131293 - StringBeginsWith and StringEndsWith

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I want to add StringBeginsWith and StringEndsWith to nsReadableUtils.  They're
very common operations.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See bug 64209 for an example of where they would be useful.

Comment 2

[jag (Peter Annema)]

I'm all for it.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I should also add UTF8ToNewUnicode while I'm there...

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: initial patch, untested

I moved jag's UTF8 conversion character sinks out of string/obsolete/.	They
don't seem obsolete to me.  :-)  I'm wondering whether I should put them in
their own file -- very few customers actually need them, so perhaps they should
be in nsUTF8Utils.h instead of nsReadableUtils.h?

Comment 5

[jag (Peter Annema)]

Comment on attachment 102703 [details] [diff] [review]
initial patch, untested

I'd say lets move our UTF8 conversion utils into a seperate file.

On String*With:
I guess the check for sub_len > src_len is pretty cheap, but very likely the
odd case, and since operator== (or rather, Equals) does a length comparison
itself, perhaps we could leave it out?

Comment 6

[Alec Flett]

Comment on attachment 102703 [details] [diff] [review]
initial patch, untested

nice! sr=alecf
I am looking forward to using the UTF8 converter class in some of my other
stuff too.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

> On String*With:
> I guess the check for sub_len > src_len is pretty cheap, but very likely the
> odd case, and since operator== (or rather, Equals) does a length comparison
> itself, perhaps we could leave it out?

We can't leave it out, since that would mean that |Substring| would be given
invalid parameters.  Or we could leave it out and make the parameters to
substring much more complicated.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: revised patch

Use a separate file.  (Code also recopied from the current version.)

Comment 9

[Johnny Stenback (:jst)]

Comment on attachment 123819 [details] [diff] [review]
revised patch

r=jst

Comment 10

[Alec Flett]

Comment on attachment 123819 [details] [diff] [review]
revised patch

this looks great! sr=alecf

Comment 11

[Alec Flett]

Comment on attachment 123819 [details] [diff] [review]
revised patch

oops, sr=alecf

Comment 12

[jag (Peter Annema)]

Comment on attachment 123819 [details] [diff] [review]
revised patch

sr=jag

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 123819 [details] [diff] [review]
revised patch

Requesting 1.4 approval -- this is low risk since all it's doing is moving code
and adding new functions that aren't used yet.	However, I think it would be
good to have it on the branch since if it's not on the branch it might make it
harder to move patches from trunk to branch (since we're likely to start using
these functions on the trunk).

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 123819 [details] [diff] [review]
revised patch

a=asa (on behalf of drivers) for checkin to 1.4.

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-05-21 15:20 -0700.