Closed
Bug 1313033
Opened 8 years ago
Closed 8 years ago
Port bug 1312991 |Get rid of nsIHTMLEditor.setDocumentTitle()| to TB and SM
Categories
(Thunderbird :: Message Compose Window, defect)
Thunderbird
Message Compose Window
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 53.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
References
Details
Attachments
(1 file, 1 obsolete file)
2.31 KB,
patch
|
aceman
:
review+
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1312991 +++ Replace GetCurrentEditor().setDocumentTitle(title); with GetCurrentEditorElement().ownerDocument.title = title; or getBrowser().contentDocument.title = title; Since getBrowser() has become more famous these days, I prefer the latter.
Assignee | ||
Comment 1•8 years ago
|
||
Notes: I prefer to use getBrowser().contentDocument, so that's what I've used in TB. Editor and SM don't have getBrowser(), so there it's GetCurrentEditorElement().contentDocument. GetCurrentEditorElement().ownerDocument as suggested in comment #0 is not correct.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8804772 -
Flags: review?(iann_bugzilla)
Attachment #8804772 -
Flags: review?(acelists)
I would like to use the same command for all 3 versions while it works. So GetCurrentEditorElement().contentDocument also for /mail .
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8804772 -
Attachment is obsolete: true
Attachment #8804772 -
Flags: review?(iann_bugzilla)
Attachment #8804772 -
Flags: review?(acelists)
Attachment #8807054 -
Flags: review?(iann_bugzilla)
Attachment #8807054 -
Flags: review?(acelists)
Comment on attachment 8807054 [details] [diff] [review] 1313033.patch (v2) Review of attachment 8807054 [details] [diff] [review]: ----------------------------------------------------------------- Thanks.
Attachment #8807054 -
Flags: review?(acelists) → review+
Comment on attachment 8807054 [details] [diff] [review] 1313033.patch (v2) r/a=me
Attachment #8807054 -
Flags: review?(iann_bugzilla) → review+
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/9fa9c0c8bbe105fb574a7e9be18c0af0de743f7f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
You need to log in
before you can comment on or make changes to this bug.
Description
•