1313150 - Remove |weak| parameter from nsIMutableArray methods

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Eric Rahm [:erahm]]

Currently nsIMutableArray.{appendElement,insertElementAt,replaceElementAt} require a |weak| param. This is rarely, if at all, ever set to |true|. Lets make this param optional and have it default to false.

Comment 1

[Julien Cristau [:jcristau] (back April 22)]

Mass wontfix for bugs affecting firefox 52.

Comment 2

[Masatoshi Kimura [:emk]]

Bug 1355216 already fixed about appendElement. But we could just remove the `weak` parameter entirely as Nathan said in that bug.

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Bug 1313150 - Remove |weak| parameter from nsIMutableArray methods.

Review commit: https://reviewboard.mozilla.org/r/191808/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191808/

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8920820 [details]
Bug 1313150 - Remove |weak| parameter from nsIMutableArray methods.

https://reviewboard.mozilla.org/r/191808/#review197198

This makes sense to me.  ~150 calls and none of them ask for weak references?  Definitely a candidate for fixing up.

I see that you changed the lone JavaScript test we have for this...how confident are we that there are no other calls from JS that we have to fixup?

Comment 5

[Masatoshi Kimura [:emk]]

Comment on attachment 8920820 [details]
Bug 1313150 - Remove |weak| parameter from nsIMutableArray methods.

https://reviewboard.mozilla.org/r/191808/#review197198

I searched insertElementAt and replaceElementAt using dxr and replaced them.
This patch contains 4 js files.

Comment 6

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 7a68de4eca81 -d e1e574000af4: rebasing 428870:7a68de4eca81 "Bug 1313150 - Remove |weak| parameter from nsIMutableArray methods. r=froydnj" (tip)
merging dom/base/nsDOMWindowUtils.cpp
merging security/manager/ssl/PKCS11ModuleDB.cpp
merging security/manager/ssl/nsNSSCertificateDB.cpp
merging security/manager/ssl/nsNSSIOLayer.cpp
merging security/manager/ssl/nsPKCS11Slot.cpp
merging xpfe/components/directory/nsDirectoryViewer.cpp
warning: conflicts while merging security/manager/ssl/nsPKCS11Slot.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 7

[Masatoshi Kimura [:emk]]

Comment on attachment 8920820 [details]
Bug 1313150 - Remove |weak| parameter from nsIMutableArray methods.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191808/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26c7003f1546
Remove |weak| parameter from nsIMutableArray methods. r=froydnj

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/26c7003f1546

Comment 10

[:aceman]

And tons of uses in c-c (e.g. calls to appendElement seem to be all with false). Should be manageable for us.

Comment 11

[Jorg K (CEST = GMT+2)]

Bug 1411069.