1313290 - Use browser specific message manager in `SocialShare.sharePage`

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I noticed that `SocialShare.sharePage` sends several messages to a specific tab's browser with `gBrowser.selectedBrowser.messageManager`, but then waits for a reply using the browser window message manager.

As far as I can tell, it would be safe to listen for a reply on the same message manager used to send.  Also, the current version happens to fail to collect page content when the Responsive Design Mode that I am working on for DevTools is used.  Switching to the browser specific MM for replies resolves this issue.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1313290 - Use tab specific MM in SocialShare.sharePage.

Review commit: https://reviewboard.mozilla.org/r/88800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88800/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e53c2b96e9a54ddcda1737dc8dc0e6b3ab62e4e

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8804995 [details]
Bug 1313290 - Use tab specific MM in SocialShare.sharePage.

https://reviewboard.mozilla.org/r/88800/#review87972

LGTM, assuming tests pass ship it!

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Thanks for the quick review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ca6314d95c2
Use tab specific MM in SocialShare.sharePage. r=mixedpuppy

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6ca6314d95c2