1313309 - Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE

Status: RESOLVED FIXED

(Toolkit :: Storage, defect, P3)

Description

[Marco Bonardo [:mak]]

SQLITE_OMIT_DECLTYPE allows prepared statements to save some memory, and our only use of it is in GetColumnDecltype API that is only used by tests to check it works :(

We should check addons usage of it, and if possible remove it.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1313309 - Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE.

Review commit: https://reviewboard.mozilla.org/r/90498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90498/

Comment 2

[Marco Bonardo [:mak]]

sorry for the reviews-spam, it's all tiny things.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8807283 [details]
Bug 1313309 - Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE.

https://reviewboard.mozilla.org/r/90498/#review90224

I double-checked the addons DXR and concur there does not seem to be any meaningfull fallout.  Thanks for the efforts to reduce library bloat!

I got three hits:
* a separate idl interface that does not overlap mozStorage's
* a query helper (possibly debug, hard to tell because of the minified JS) in an addon last updated 5 years ago with 3 users
* a comment in a storage-using library that seemed to be a note reminding of the available (or skipped?) functions.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/059f143b7894
Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE. r=asuth

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/059f143b7894