Closed
Bug 1313405
Opened 8 years ago
Closed 8 years ago
MP4Demuxer::NotifyDataRemoved looks bogus
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
INVALID
Tracking | Status | |
---|---|---|
firefox52 | --- | affected |
People
(Reporter: froydnj, Unassigned)
Details
We have: https://dxr.mozilla.org/mozilla-central/rev/3f4c3a3cabaf94958834d3a8935adfb4a887942d/dom/media/fmp4/MP4Demuxer.cpp#200 void MP4Demuxer::NotifyDataRemoved() { for (uint32_t i = 0; i < mDemuxers.Length(); i++) { mDemuxers[i]->NotifyDataArrived(); } } Shouldn't that NotifyDataArrived call be NotifyDataRemoved?
Comment 1•8 years ago
|
||
No... There's no MP4TrackDemuxer::NotifyDataRemoved to start with, and all we care about is to set a flag indicating to re calculate the buffered ranges.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Reporter | ||
Comment 2•8 years ago
|
||
(In reply to Jean-Yves Avenard [:jya] from comment #1) > There's no MP4TrackDemuxer::NotifyDataRemoved to start with, and all we care > about is to set a flag indicating to re calculate the buffered ranges. That is...non-obvious. :(
Comment 3•8 years ago
|
||
Feel free to remove MP4TrackDemuxer::NotifyDataArrived with something like NotifyDataArrivedOrGotRemoved or whatever name is more obvious to you :) NotifyDataRemoved is only use with MSE for what it's worth.
You need to log in
before you can comment on or make changes to this bug.
Description
•