Closed Bug 1313418 Opened 8 years ago Closed 8 years ago

[e10s] Dropdown menu list is using wrong font family & size and have too much useless space between items

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Version:
48 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
VERIFIED DUPLICATE of bug 1300784

People

(Reporter: Virtual, Unassigned)

Details

(Keywords: nightly-community)

Attachments

(5 files)

e10s disabled.png
3.86 KB, image/png
Details
e10s enabled.png
3.72 KB, image/png
Details
Firefox 51 [e10s=enabled].png
19.50 KB, image/png
Details
Firefox 52 [e10s=enabled].png
22.09 KB, image/png
Details
Firefox 52 [e10s=disabled].png
21.95 KB, image/png
Details 
STR:
1. Open this website page - https://bugzilla.mozilla.org/enter_bug.cgi?product=Core
2. Open second "Platform" dropdown menu list
3. See that visual appearance of dropdown menu list with e10s enabled is different compared to dropdown menu list with e10s disabled.

Most notable changes are that:
- font family used in foreground text isn't used in dropdown menu list
- there are too much useless space between items in dropdown menu list
Also size of the font is different.
Summary: [e10s] Dropdown menu list is using wrong font family and have too much useless space between items → [e10s] Dropdown menu list is using wrong font family & size and have too much useless space between items
[Tracking Requested - why for this release]: Regression

On stable builds the regression started in Firefox 48, where e10s is by default enabled.
status-firefox49: --- → affected
status-firefox50: --- → affected
status-firefox51: --- → affected
status-firefox52: --- → affected
status-firefox-esr45: --- → unaffected
tracking-firefox49: --- → ?
tracking-firefox50: --- → ?
tracking-firefox51: --- → ?
tracking-firefox52: --- → ?
There even was some change between Firefox 51 and Firefox 52 in this issue.
Version: Trunk → 48 Branch
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Bug #1300784 is only about combining e10s and non-e10s <select> dropdown mechanisms, not about regression that dropdown menu list is using wrong font family & size and have too much useless space between items.
Status: RESOLVED → REOPENED
Depends on: 1300784
Resolution: DUPLICATE → ---
The spacing between items was a conscious design decision.
Flags: needinfo?(markgolbeck08)
Is it a regression that the popup uses a different font-family than the button in the page? What happened before this patch if the font-family on the page was set to Georgia, for example?

As Neil commented, the difference between e10s and non-e10s will be fixed with bug 1300784.
Flags: needinfo?(markgolbeck08)
The e10s team triaged a number of bugs about this. Basically we switched UI elements for the drop down, and because of that, the fonts and layout changed somewhat. The consensus was that the new layout was better. Regardless, we decided we would not attempt to fix these issues since e10s is replacing non-e10s so minor font/layout differences in the dropdown are irrelevant.
Status: NEW → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → WONTFIX
What are the reasons for:
-making font smaller
-making dropdown text using other font family than on button
-increasing that much space between items, which is useless on non-touch devices
-changing appearance to be inconsistent compared to other browser?
Tracking 52- based on resolution.
tracking-firefox52: ? → -
Per comment #14, track 51-.
tracking-firefox51: ? → -
Hey Philipp, what do you think about the difference between the font being used on the button and what shows up in the popup?

You can look at https://bug1313418.bmoattachments.org/attachment.cgi?id=8805455 to see the difference. We didn't change the font on the button because we are worried about web compat.
Flags: needinfo?(philipp)
Please, see comment #15
Flags: needinfo?(markgolbeck08)
Flags: needinfo?(jmathies)
(In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #15)
> What are the reasons for:
> -making font smaller
> -making dropdown text using other font family than on button
> -increasing that much space between items, which is useless on non-touch
> devices
> -changing appearance to be inconsistent compared to other browser?

As I said, we switched UI elements and so the layout changed. Feel free to file bugs on individual issues.
Flags: needinfo?(jmathies)
OK, but I was hoping that we could omit bureaucracy and deal with these issues here... seems not. ;)
Flags: needinfo?(philipp)
Flags: needinfo?(markgolbeck08)
(In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #21)
> OK, but I was hoping that we could omit bureaucracy and deal with these
> issues here... seems not. ;)

Looks like we have newer regressions in this area due to the select styling and gpu changes, so not really the same styling issues we triaged under e10s.
(In reply to Jim Mathies [:jimm] from comment #22)
> (In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #21)
> > OK, but I was hoping that we could omit bureaucracy and deal with these
> > issues here... seems not. ;)
> 
> Looks like we have newer regressions in this area due to the select styling
> and gpu changes, so not really the same styling issues we triaged under e10s.

I reported the GPU Process changes and regressions to select dropdown menu list (especially about these blurry and not sharp fonts in text) in bug #1315568,
but this bug wasn't about it, as it was reported before GPU Process was landed,
it's about regression from bug #1091592, which is now tracked separately as you wanted.
I am assuming bug 1300784 will fix this. Too late for 49 and 50, both are wontfix now.
status-firefox49: affected → wontfix
status-firefox50: affected → wontfix
No longer blocks: fxe10s, e10s-select, 1316404, e10s, 1091592, 1316405, 1316406
Status: RESOLVED → VERIFIED
Has Regression Range: yes → ---
Has STR: yes → ---
status-firefox49: wontfix → ---
status-firefox50: wontfix → ---
status-firefox51: affected → ---
status-firefox52: affected → ---
status-firefox-esr45: unaffected → ---
tracking-firefox50: - → ---
tracking-firefox51: - → ---
tracking-firefox52: - → ---
No longer depends on: 1300784
Keywords: multiprocess, regression, ux-consistency, ux-minimalism
Resolution: WONTFIX → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: