Closed
Bug 1313489
Opened 8 years ago
Closed 8 years ago
Convert XPCOM test TestDeadlockDetectorScalability to a gtest
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(2 files)
|
6.62 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
|
9.63 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Convert xpcom/tests/TestDeadlockDetectorScalability.cpp to a gtest and move to xpcom/tests/gtest/.
|
Assignee | |
Comment 1•8 years ago
|
||
MozReview-Commit-ID: HSS4Sf7O1I6
Attachment #8807380 -
Flags: review?(nfroyd)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•8 years ago
|
||
This converts the tests to gtests. Most of them are just runtime tests and just
hava dummy assertion that everything ran. One test remains disabled, although
it's still built-in. You can run the disabled test with the following command:
> GTEST_ALSO_RUN_DISABLED_TESTS=1 ./mach gtest DeadlockDetectorScalability.*
MozReview-Commit-ID: 57rxjiZKjQ6
Attachment #8807381 -
Flags: review?(nfroyd)
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd31ed5e8449
|
||
Updated•8 years ago
|
Attachment #8807380 -
Flags: review?(nfroyd) → review+
|
|
||
Updated•8 years ago
|
Attachment #8807381 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b875e45ae35c
|
|
Assignee | |
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a062f72097d95c6f8c92515380d889286d0daa3 Bug 1313489 - Part 1: Remove dead code. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/276b093c968ffc889f465161b7aa1fe80c796988 Bug 1313489 - Part 2: Convert DeadlockDetectorScalability to a gtest. r=froydnj
|
||
Comment 6•8 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/01800003ec3b043995e4ec1daaaf827e7ee2bbee for OS X builds being silly and continuing to burn like https://treeherder.mozilla.org/logviewer.html#?job_id=38802396&repo=mozilla-inbound even after the one where they started doing it was backed out for something else.
|
|
Assignee | |
Comment 7•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec5c37d6dec1
|
|
Assignee | |
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b0acef284ad19804d1d3d681cba2f5ba6622377 Bug 1313489 - Part 1: Remove dead code. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/54098e53a5841ce10c1f3fc2bb507b77587e7d7c Bug 1313489 - Part 2: Convert DeadlockDetectorScalability to a gtest. r=froydnj
|
|
||
Comment 9•8 years ago
|
||
Also had to backout this out to get no failing hunks on backout of bug 1313488: https://hg.mozilla.org/integration/mozilla-inbound/rev/3aa99c2ab46d92ca0f1480d36aed87b49c575efd https://hg.mozilla.org/integration/mozilla-inbound/rev/2e21f3a89751b5bf85d8c10b983dfcc845452cf8
Flags: needinfo?(erahm)
|
|
Assignee | |
Comment 11•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd51f48870d92772efbf6156c98e1cb92c616c77 Bug 1313489 - Part 1: Remove dead code. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/03fc16d0df1b81173e37fd65c515f335e2496a08 Bug 1313489 - Part 2: Convert DeadlockDetectorScalability to a gtest. r=froydnj
|
||
Comment 12•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fd51f48870d9 https://hg.mozilla.org/mozilla-central/rev/03fc16d0df1b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•