1313762 - SharedWorker::PreHandleEvent doesn't deal with widget events

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

The method queues[1] only DOMEvents, but what if DOMEvent hasn't been created yet and there is just WidgetEvent? We do nothing with those in case the worker is frozen.
I guess we should explicitly create DOMEvent and queue that, something similar to
http://searchfox.org/mozilla-central/rev/445097654c1cc1098ee0171a29c439afe363a588/dom/events/EventListenerManager.cpp#1231-1237


[1] http://searchfox.org/mozilla-central/rev/445097654c1cc1098ee0171a29c439afe363a588/dom/workers/SharedWorker.cpp#187

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

(it is possible that we don't currently dispatch WidgetEvents without DOMEvent in workers)

Comment 2

[Andrea Marchesini [:baku]]

We just dispatch DOMEvents in workers.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

by accident. I don't anything guaranteeing that. And dispatching widget events should be just fine.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: event2.patch

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8809745 [details] [diff] [review]
event2.patch


> nsresult
> SharedWorker::PreHandleEvent(EventChainPreVisitor& aVisitor)
> {
>   AssertIsOnMainThread();
> 
>-  nsIDOMEvent*& event = aVisitor.mDOMEvent;
>+  nsCOMPtr<nsIDOMEvent> event = aVisitor.mDOMEvent;
>+  if (!event) {
>+    nsCOMPtr<EventTarget> et =
>+      do_QueryInterface(aVisitor.mEvent->mOriginalTarget);
Useless QI. mOriginalTarget is nsCOMPtr<dom::EventTarget>.

>+    event = EventDispatcher::CreateEvent(et, aVisitor.mPresContext,
>+                                         aVisitor.mEvent, EmptyString());
>+  }
You don't want to create the event all the time. Only when we're frozen.
So, move the new code inside 'if (IsFrozen())' check.



Those fixed, r+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f11622c5a78
SharedWorker::PreHandleEvent must be able to deal with widget events, r=smaug

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3f11622c5a78