1314547 - HTMLMediaElement::InitializeDecoderAsClone() shouldn't call MediaDecoder::SetMediaSeekableOnlyInBufferedRanges()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/f5c9e9a249637c9abd88754c8963ecb3838475cb/dom/html/HTMLMediaElement.cpp#3711

The same reason as bug 1314529. MediaDecoder should discover this capability during decoding.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1314547. Part 1 - remove the call to MediaDecoder::SetMediaSeekableOnlyInBufferedRanges().

Review commit: https://reviewboard.mozilla.org/r/90310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90310/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1314547. Part 2 - remove unused public functions.

Review commit: https://reviewboard.mozilla.org/r/90312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90312/

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8807029 [details]
Bug 1314547. Part 1 - remove the call to MediaDecoder::SetMediaSeekableOnlyInBufferedRanges().

https://reviewboard.mozilla.org/r/90310/#review90242

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8807030 [details]
Bug 1314547. Part 2 - remove unused public functions.

https://reviewboard.mozilla.org/r/90312/#review90244

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5890b5a266b0
Part 1 - remove the call to MediaDecoder::SetMediaSeekableOnlyInBufferedRanges(). r=cpearce
https://hg.mozilla.org/integration/autoland/rev/6ff21ea6c47e
Part 2 - remove unused public functions. r=cpearce

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5890b5a266b0
https://hg.mozilla.org/mozilla-central/rev/6ff21ea6c47e