1314568 - Silence warning from nsEffectiveTLDService::GetBaseDomain() when this gets called from DocGroup::GetKey() with null argument

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1303196 +++

Silence warning from nsEffectiveTLDService::GetBaseDomain() when this gets called from DocGroup::GetKey() with null argument.

This was introduced in bug 1303196 here:
https://hg.mozilla.org/mozilla-central/rev/fe339dd59a01#l1.26

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1314568.patch

See
https://dxr.mozilla.org/comm-central/rev/2c773b97167252cedcba0be0c7af9d4cab192ef5/mozilla/dom/base/nsWindowMemoryReporter.cpp#774
for similar treatment.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8806667 [details] [diff] [review]
1314568.patch

Review of attachment 8806667 [details] [diff] [review]:
-----------------------------------------------------------------

Good plan. I noticed this while I was developing the patch, but I suppose I never actually fixed it. Thank you very much!

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1314568.patch

Thanks!
Carrying forward Michael's r+.
Changed the reviewer to "mystor" so it gets landed with the correct reviewer.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5156607f031
Silence warning from nsEffectiveTLDService::GetBaseDomain(). r=mystor

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b5156607f031