Closed
Bug 1314847
Opened 8 years ago
Closed 8 years ago
Sign mar files as part of signingscriptworker
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Callek, Assigned: Callek)
Details
Attachments
(1 file)
We need to invoke mar signing as part of taskcluster, and probably beetmove these somehow
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8806978 [details] Bug 1314847 - Sign mar files as part of signingscriptworker -- f?kmoir This is explicitly a WIP, and doesn't block our target of "beetmove first" but probably blocks updates entirely. This patch is touching only l10n, but mainly because I ran out of time tonight to touch anything else...
Attachment #8806978 -
Flags: feedback?(kmoir)
Attachment #8806978 -
Flags: feedback?(dustin)
Assignee | ||
Updated•8 years ago
|
Attachment #8806978 -
Flags: feedback?(dustin)
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8806978 [details] Bug 1314847 - Sign mar files as part of signingscriptworker -- f?kmoir https://reviewboard.mozilla.org/r/90216/#review90106
Attachment #8806978 -
Flags: review+
Updated•8 years ago
|
Attachment #8806978 -
Flags: feedback?(kmoir) → feedback+
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8806978 [details] Bug 1314847 - Sign mar files as part of signingscriptworker -- f?kmoir https://reviewboard.mozilla.org/r/90216/#review90120 This is OK to land as-is, but hopefully a useful change suggested below that would only take a few minutes to put together. ::: taskcluster/taskgraph/transforms/nightly_l10n_signing.py:26 (Diff revision 1) > + extensions = ['.apk'] > + signing_formats = ["jar"] > + else: > + extensions = ['.tar.bz2', '.complete.mar'] > + signing_formats = ["gpg", "mar"] It's not clear from reading that these lists are zipped. Could you switch it around to something like job_specs = [ { 'extensions': ['.apk'], 'format': 'jar', }, ] else: job_specs = [ { 'extensions': ['.tar.bz2', '.checksums'], 'format': 'gpg', }, { 'extensions': ['.complete.mar'], 'format': 'mar', } This would have the benefit of removing the `.tar.bz2` special-case below.
Attachment #8806978 -
Flags: review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8806978 [details] Bug 1314847 - Sign mar files as part of signingscriptworker -- f?kmoir This is a landing-ready (I think) patch. Thanks!
Attachment #8806978 -
Flags: feedback?(kmoir)
Comment 7•8 years ago
|
||
mozreview-review |
Comment on attachment 8806978 [details] Bug 1314847 - Sign mar files as part of signingscriptworker -- f?kmoir https://reviewboard.mozilla.org/r/90216/#review90812
Attachment #8806978 -
Flags: review+
Updated•8 years ago
|
Attachment #8806978 -
Flags: feedback?(kmoir) → feedback+
Assignee | ||
Comment 8•8 years ago
|
||
This landed on date, but looks like we're going to go with Bug 1316214 as our fate.
Assignee | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•