1314900 - Dump MIR expressions

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P3)

Description

[Hannes Verschore [:h4writer]]

I added a convenient way to create a list of MIR expressions. It makes it easier to see which GVN we forgot. I did this as a side-patch, but I see no reason why not get it in the tree for other to replicate?

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: Patch

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8807088 [details] [diff] [review]
Patch

Review of attachment 8807088 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/JitSpewer.h
@@ +63,5 @@
>      /* Information of tracked opt strats */ \
>      _(OptimizationTracking)                 \
>      /* Debug info about the I$ */           \
>      _(CacheFlush)                           \
> +    /* Debug info about the I$ */           \

nit: bad copy/pasto

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8807088 [details] [diff] [review]
Patch

Review of attachment 8807088 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.

::: js/src/jit/IonAnalysis.cpp
@@ +4666,5 @@
> +
> +static void
> +DumpDefinition(GenericPrinter& out, MDefinition* def, size_t depth)
> +{
> +    def->PrintOpcodeName(out, def->op());

Nit: s/def->/MDefinition::/

::: js/src/jit/JitSpewer.h
@@ +63,5 @@
>      /* Information of tracked opt strats */ \
>      _(OptimizationTracking)                 \
>      /* Debug info about the I$ */           \
>      _(CacheFlush)                           \
> +    /* Debug info about the I$ */           \

See Benjamin's comment.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d23f30439519
IonMonkey - Add flag to IONFLAGS to spew the MIR expressions, r=jandem

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d23f30439519