1315152 - I can't build on VisualStudio 2015 on Japanese locale after landing bug 1260626.

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Mantaroh Yoshinaga[:mantaroh]]

+++ This bug was initially created as a clone of Bug #1260626 +++

I faced the build failure due to file encoding.
The change of bug 1260626 contained the multi-byte code.[1] 
In Japanese environment, The VisualStudio will identify as CP932.

[1] https://hg.mozilla.org/mozilla-central/rev/851d4bd145a4#l1.74

Comment 1

[Michael Leu[:Lenzak](UTC+8)]

The patch in bug1260626 results in build failure under Traditional Chinese environment, too

We can workaround it by deleting the multibyte char here.
https://dxr.mozilla.org/mozilla-central/rev/3b80868f7a8fe0361918a814fbbbfb9308ae0c0a/security/manager/ssl/tests/unit/pkcs11testmodule/pkcs11testmodule.cpp#104

It seems that this patch affects language environment with multibyte char.

Comment 2

[Masatoshi Kimura [:emk]]

Bug 1313280 will fix this.

Comment 3

[Masatoshi Kimura [:emk]]

Or we can fix this by using UTF-8 string literals:
> static const char TestSlot2Description[] = u8"Test PKCS11 Slot 二";

Comment 4

[Masatoshi Kimura [:emk]]

(In reply to Masatoshi Kimura [:emk] from comment #3)
> Or we can fix this by using UTF-8 string literals:
> > static const char TestSlot2Description[] = u8"Test PKCS11 Slot 二";

Ah, this will not work because it will not change the execution character set.

Comment 5

[Masatoshi Kimura [:emk]]

s/execution character set/source character set/

Sorry for the bugspam.

Comment 6

[:Cykesiopka]

Sorry about that.

Anyways, here's my plan:
1. I will attach a patch containing a workaround that should unbreak non-Western environments and keep PSM tests passing as well.
2. I will wait to see if Bug 1313280 gets fixed in a reasonable time, since that is the proper fix, and we do want to keep the multibyte char to test PKCS #11 UTF-8 handling.
3. If Bug 1313280 doesn't progress quickly enough, I'll get the workaround patch reviewed and landed.

Comment 7

[:Cykesiopka]

Attachment: bug1315152_workaround-msvc-source-charset-issue_v1.patch

Workaround patch.

Comment 8

[Masatoshi Kimura [:emk]]

Fixed by bug 1315152.

For the record, a better workaround would be use utf-8 literals *and* universal character name (UCN):
   static const char TestSlot2Description[] = u8"Test PKCS11 Slot \u4E8C";