1315287 - update docker-worker:image:taskclusterprivate/upload_symbols:0.0.3

Status: RESOLVED FIXED

(Taskcluster Graveyard :: Docker Images, defect)

Description

[Kim Moir [:kmoir] ET]

It uploads target.crashreporter-symbols.zip when it should upload target.crashreporter-symbols-full.zip 

See https://bugzilla.mozilla.org/show_bug.cgi?id=1314345#c9

root@f1402077dc31:/tmp# cat bin/upload.sh 
#! /bin/bash
set -e
# checkout the script
source $(dirname $0)/checkout-script.sh
# Check that we have a taskid to checkout
if [ -z ${ARTIFACT_TASKID} ]; then
    echo "Please set ARTIFACT_TASKID. Exiting"
    exit 0
fi
# grab the symbols from an arbitrary task
symbol_url=https://queue.taskcluster.net/v1/task/${ARTIFACT_TASKID}/artifacts/public/build/target.crashreporter-symbols.zip
wget ${symbol_url}
# run
symbol_zip=$(basename ${symbol_url})
script_name=$(basename ${SCRIPT_PATH})
python -u ${script_name} ${symbol_zip}

I couldn't find where the dockerfile for docker-worker:image:taskclusterprivate/upload_symbols:0.0.3 was stored, perhaps in a private repo since it's a private image

Comment 1

[(not currently active) Ted Mielczarek]

That image was created as part of bug 1168979, the Dockerfile is in this repo: https://github.com/acmiyaguchi/upload-symbols

Comment 2

[(not currently active) Ted Mielczarek]

(I would have linked that on your other bug yesterday but I could not recall it offhand and I lost track of it!)

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Moving that to testing/docker in the process would probably be a good idea.

Comment 4

[Kim Moir [:kmoir] ET]

Attachment: bug1315287.patch

patch to move upload-symbols dockerfile in tree

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8807642 [details] [diff] [review]
bug1315287.patch

Review of attachment 8807642 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  There's some trailing whitespace in the Dockerfile that could be cleaned up.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18a98f6dabd9
update docker-worker:image:taskclusterprivate/upload_symbols:0.0.3 r=dustin DONTBUILD

Comment 7

[Kim Moir [:kmoir] ET]

Attachment: patch with whitespace fixed

Comment 8

[Kim Moir [:kmoir] ET]

Do I have to do anything to create the new docker image, according to this is it all automatic?

https://docs.taskcluster.net/tutorial/gecko-docker-images

Comment 9

[(not currently active) Ted Mielczarek]

Unfortunately you'll have to manually build this and publish it because it needs to include the Socorro authentication token. bug 1253620 covers adding a proxy to taskcluster to avoid the need to bake the token into the image.

Comment 10

[Kim Moir [:kmoir] ET]

So to rebuild the docker image for the signing upload I need the socorro token which I don't have.  And presumably I need to publish it to a private place too. Anyone have any pointers to this data?

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

I think I have the rights to push to taskclusterprivate.  Which means I can also pull from it and find the socorro token..

Comment 12

[(not currently active) Ted Mielczarek]

I dunno where it's stored, but there's a puppet module to add it to buildbot builders:
https://dxr.mozilla.org/build-central/source/puppet/modules/slave_secrets/manifests/crash_stats_api_token.pp

You can always have coop generate a new one by logging into crash-stats. That's all we did originally...

Comment 13

[Dustin J. Mitchell [:dustin] (he/him)]

OK, pushed the updated version from attachment 8807659 [details] [diff] [review] as 0.0.4.

Comment 14

[Dustin J. Mitchell [:dustin] (he/him)]

0.0.4: digest: sha256:c3a5cce3e37aba59971462a6a9ddd54af7253e982115776b310c189128b5458f size: 2612

if anyone cares :)

Comment 15

[Kim Moir [:kmoir] ET]

thanks dustin!

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/18a98f6dabd9

Comment 17

[Kim Moir [:kmoir] ET]

Attachment: bug1315287-2.patch

patch to use the new image

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1e5b5c23216
update docker-worker:image:taskclusterprivate/upload_symbols:0.0.3 r=kmoir DONTBUILD

Comment 19

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c1e5b5c23216