Closed Bug 1315289 Opened 8 years ago Closed 8 years ago

Use correct API for opening a source in the debugger

Categories

(DevTools :: Debugger, defect, P1)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: jlong, Assigned: jlong)

Details

Attachments

(1 file)

1315289.patch
2.91 KB, patch
jlast
: review+
Details | Diff | Splinter Review 
Bug 1313197 introduced a regression because we don't call the right debugger API. Will fix here and make sure a test covers it.
Attached patch 1315289.patch — — Splinter Review 
This fixes it and also re-enables the test to make sure we don't break it again.
Attachment #8807709 - Flags: review?(jlaster)
Assignee: nobody → jlong
Priority: -- → P1
Comment on attachment 8807709 [details] [diff] [review]
1315289.patch

Review of attachment 8807709 [details] [diff] [review]:
-----------------------------------------------------------------

looks good
Attachment #8807709 - Flags: review?(jlaster) → review+
Pushed by jlong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2acfe066887
Use correct API for opening a source in the debugger r=me
https://hg.mozilla.org/mozilla-central/rev/e2acfe066887
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: