1315480 - LibreOffice/MS Office integration: Convert image data referencing MIME parts via imap/mailbox URLs to data URLs (for viewed messages)

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Jorg K (CEST = GMT+2)]

Since we're talking to TDF/LibreOffice as a new home for Thunderbird, let's keep everybody happy by improving the interoperability.

Currently pictures copied from TB to *Office end up as ugly placeholders, in MS Office pasting invisibly and in LibreOffice showing some funny imap/mailbox URL.

We can improve this by placing the images as data URLs onto the clipboard.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1315480_copy_data_urls.patch

Covers the copy/drag of a part of content + the context menu "Copy Image" case.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8809368 [details] [diff] [review]
bug1315480_copy_data_urls.patch

Review of attachment 8809368 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I haven't tested it yet. I'll get to this in the next 24 hours.

Nice effort that will keep our *Office users happy ;-)

::: mail/base/content/mailWindow.js
@@ +68,5 @@
> +  let sourceDoc = getBrowser().contentDocument;
> +  let selection = sourceDoc.getSelection();
> +  let draggedImg = null; // Will be set to the img for single image drag.
> +  for (let img of sourceDoc.images) {
> +    if (/^(http|data):/.test(img.src)) {

Further down you do:
if (/^(https?|data):/i.test(img.src)) {

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8809368 [details] [diff] [review]
bug1315480_copy_data_urls.patch

Ain't workin' ;-(

Test case: HTML message with two embedded images. Select all in the original message, drag onto a composition. Result: Only one image dragged over.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1315480_copy_data_urls.patch

Now all the dragged material should be copied

Comment 5

[Jorg K (CEST = GMT+2)]

Sorry, now the test case from comment #3 works, but the single image drag doesn't. It inserts a imap: URL.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: bug1315480_copy_data_urls.patch

Third time's a charm?

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8809538 [details] [diff] [review]
bug1315480_copy_data_urls.patch

(In reply to Magnus Melin from comment #6)
> Third time's a charm?

Yep. r=jorgk.

This will keep our *Office friends happy.

Comment 8

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/c8666b9f31bc868950a698b2cc28896d45a09030 -> FIXED

Comment 9

[Jorg K (CEST = GMT+2)]

I noticed that this doesn't work when dragging embedded images from other compose windows.

Or would you like a new bug for that?

Comment 10

[Magnus Melin [:mkmelin]]

Yes, let's limit this bug to viewed messages.

Comment 11

[Jorg K (CEST = GMT+2)]

OK, to be continued in bug 1317049.

Comment 12

[Jorg K (CEST = GMT+2)]

You might want to port this to SM.