Closed
Bug 1315582
Opened 8 years ago
Closed 8 years ago
Try recreate ImageContainer IPDL objects before creating Images
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: mattwoodrow, Unassigned)
References
Details
Attachments
(1 file)
|
1.18 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
These functions get called from the media threads, and sometimes we've lost the IPDL objects due to a crash. We then assert in TextureClient::CreateForYCbCr because our allocator is dead. This is a band-aid (since we're checking for validity on the wrong thread, and it could change between now and when we actually use it), but it does fix a common crash. Fixing this properly isn't simple, but probably worth doing.
Attachment #8808023 -
Flags: review?(dvander)
Comment on attachment 8808023 [details] [diff] [review] rebuild-image-client Review of attachment 8808023 [details] [diff] [review]: ----------------------------------------------------------------- Yes, we should fix this... could you file a follow-up to at least get it on record? From a sample size of 1: cleaning up raciness of async layers has fixed real crashes.
Attachment #8808023 -
Flags: review?(dvander) → review+
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3677545baae2 Try recreate ImageContainer IPDL object before creating Images. r=dvander
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3677545baae2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•