1315651 - Crash in mozilla::dom::HTMLCanvasElement::GetCompositorBackendType

Status: RESOLVED FIXED

(Core :: Graphics, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-f210c189-bb1b-456c-bff8-647b82161107.
=============================================================

Seen while looking at Nightly Fennec crash stats: http://bit.ly/2fxfMic. Small volume crash that started with build 20161106030203

Comment 1

[Andrew McCreight [:mccr8]]

I also see two crashes in the 20161105030211 build.

Milan, could this be a regression from bug 1309913? That is in the same time window, and touched the files that are crashing.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Most likely.  Looking at it now.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Bug 1315651: Check for null layer manager - we could be asking about the layer backend without it being there.

Review commit: https://reviewboard.mozilla.org/r/91092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91092/

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8808251 [details]
Bug 1315651: Check for null layer manager - we could be asking about the layer backend without it being there.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/91092/diff/1-2/

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Jamie, is this a startup crash on any of the devices you have?

Comment 6

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 8808251 [details]
Bug 1315651: Check for null layer manager - we could be asking about the layer backend without it being there.

https://reviewboard.mozilla.org/r/91092/#review90874

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d01138a95d9
Check for null layer manager - we could be asking about the layer backend without it being there. r=gw280

Comment 8

[Jamie Nicol [:jnicol]]

Guessing the above commit will fix it, but no I couldn't reproduce this on my nexus 5x. tried going to a canvas page, opening/closing tabs, rotating screen, minimising app, etc. Under what circumstances would we expect the layer manager to be null?

Comment 9

[Milan Sreckovic [:milan] (needinfo for best results)]

Thanks for testing, and a valid question.  Perhaps a race condition?

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1d01138a95d9