Closed
Bug 1315901
Opened 8 years ago
Closed 8 years ago
Various MIPS breakage
Categories
(Core :: JavaScript Engine: JIT, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: lth, Assigned: lth)
Details
Attachments
(3 files)
1.38 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
3.07 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
21.25 KB,
patch
|
hev
:
review+
|
Details | Diff | Splinter Review |
While triaging some bugs I found that the shell would no longer compile with the MIPS simulators due to several unrelated reasons. Some of these problems are mine (caused by the wasm baseline compiler or MacroAssembler refactoring); some are in the simulator.
Assignee | ||
Comment 1•8 years ago
|
||
Separate MIPS from ARM in Wasm baseline compiler setup because MIPS does not have the ARM scratch register (duh).
Attachment #8808531 -
Flags: review?(nicolas.b.pierron)
Assignee | ||
Comment 2•8 years ago
|
||
When I refactored cmpPtrSet in bug 1268006 I neglected to move all the instantiations of that template for MIPS64. (This is why templates are bad :) So move them.
Attachment #8808532 -
Flags: review?(nicolas.b.pierron)
Assignee | ||
Comment 3•8 years ago
|
||
Make MIPS simulators compile - mostly by fixing printf format strings - and reduce the warning volume a little by cleaning up a header file.
Attachment #8808534 -
Flags: review?(r)
Comment 4•8 years ago
|
||
Comment on attachment 8808532 [details] [diff] [review] bug1315901-masm-mips64.patch Review of attachment 8808532 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jit/mips64/MacroAssembler-mips64-inl.h @@ +411,5 @@ > } > > +template<> > +inline void > +MacroAssembler::cmpPtrSet(Assembler::Condition cond, Address lhs, ImmPtr rhs, I do not think check_macroassembler_style works with template specializations yet.
Attachment #8808532 -
Flags: review?(nicolas.b.pierron) → review+
Updated•8 years ago
|
Attachment #8808531 -
Flags: review?(nicolas.b.pierron) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8808534 [details] [diff] [review] bug1315901-mips-simulators.patch Review of attachment 8808534 [details] [diff] [review]: ----------------------------------------------------------------- Thank you.
Attachment #8808534 -
Flags: review?(r) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Try run with this and other patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=193cdd4713be7528e5de69c0439c3213cb05116d
Assignee | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0723acb2c1375e9bc0631ed47a6893650ab72e7a Bug 1315901 - separate MIPS and ARM in wasm baseline compiler. r=nbp https://hg.mozilla.org/integration/mozilla-inbound/rev/7625f17309bf6bb28d8ae9adb61c031e965c8247 Bug 1315901 - instantiate cmpPtrSet on MIPS64 for all operand types. r=nbp https://hg.mozilla.org/integration/mozilla-inbound/rev/560a32f9d49fe46e9d64d77b8efd7f69ef0ead64 Bug 1315901 - make MIPS simulators compile + reduce warnings a little. r=hev
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0723acb2c137 https://hg.mozilla.org/mozilla-central/rev/7625f17309bf https://hg.mozilla.org/mozilla-central/rev/560a32f9d49f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•