Closed
Bug 1316000
Opened 8 years ago
Closed 8 years ago
Remove old Yahoo! Messenger support
Categories
(Chat Core :: Yahoo! Messenger, defect)
Chat Core
Yahoo! Messenger
Tracking
(Not tracked)
RESOLVED
FIXED
Instantbird 52
People
(Reporter: clokep, Assigned: clokep)
References
Details
Attachments
(2 files, 1 obsolete file)
749.04 KB,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
87.30 KB,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
The current Yahoo! Messenger code we have does not work. I can't seem to find any reference to it, but Pidgin also removed support.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
A link to an announcement about this: https://web.archive.org/web/20160730080614/https://help.yahoo.com/kb/yahoo-messenger-for-web/SLN26860.html
Assignee | ||
Comment 2•8 years ago
|
||
I tested this by ensuring that yahoo didn't appear in the list of new accounts anymore. Trying to connect to Yahoo showed a message saying it doesn't work and didn't try to reconnect.
Attachment #8808702 -
Flags: review?(aleth)
Comment 3•8 years ago
|
||
Comment on attachment 8808702 [details] [diff] [review] Patch v1 Review of attachment 8808702 [details] [diff] [review]: ----------------------------------------------------------------- Doesn't this also need a prpl patch? yahoo is still listed in purple/libpurple/moz.build Looks good otherwise. ::: im/locales/en-US/chrome/instantbird/accountWizard.properties @@ +7,5 @@ > # to the target language / location and comma delimited. > # Exceeding 4 protocols may cause scrolling. A list of the > # available protocols can be found at > # https://wiki.instantbird.org/Protocol_Identifiers > +topProtocol.list=prpl-gtalk,prpl-twitter,prpl-aim,prpl-irc How about replacing yahoo with XMPP?
Assignee | ||
Comment 4•8 years ago
|
||
Remove both Yahoo and MySpace from libpurple. These have both been removed by Pidgin.
Attachment #8808978 -
Flags: review?(aleth)
Assignee | ||
Comment 5•8 years ago
|
||
Added XMPP to the top protocols list.
Attachment #8808702 -
Attachment is obsolete: true
Attachment #8808702 -
Flags: review?(aleth)
Attachment #8808995 -
Flags: review?(aleth)
Comment 6•8 years ago
|
||
Comment on attachment 8808978 [details] [diff] [review] Purple Patch v1 Review of attachment 8808978 [details] [diff] [review]: ----------------------------------------------------------------- rs+ I hope this doesn't bitrot the libpurple update patch that is waiting for flo's review too much...
Attachment #8808978 -
Flags: review?(aleth) → review+
Comment 7•8 years ago
|
||
Comment on attachment 8808995 [details] [diff] [review] Patch v2 Review of attachment 8808995 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8808995 -
Flags: review?(aleth) → review+
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/9371fb54aca0ac6f5ef39ec2b047246b2dd9f005 https://hg.mozilla.org/users/florian_queze.net/purple/rev/b9d75e616955a6271c488a84443c14129ee666e1 Thanks!
Assignee | ||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 52
Assignee | ||
Comment 9•8 years ago
|
||
Oops, I had the wrong prpl ID in the account wizard: https://hg.mozilla.org/comm-central/rev/dc1b2bd19227d32fbb4ef5d5ff7ebc12e1641079
You need to log in
before you can comment on or make changes to this bug.
Description
•