13163 - SCRIPT tag TYPE attribute ignores "version="

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[KerryGinn]

SCRIPT tags without the deprecated LANGUAGE attribute are executed regardless of
the version number. E.g., should not this SCRIPT tag should be ignored:

	<SCRIPT TYPE="text/javascript; version=4.6">
		alert("Greetings from the Year 2038.");
	</SCRIPT>

Another opinion is here:

	http://www.deja.com/getdoc.xp?AN=385556726

Comment 1

[cbegle]

troy, is this yours?  the script tag parsing stuff in nsHTMLContentSink.cpp
appears to belong to you.

Comment 2

[troy]

Vidur, I assume this is you

Comment 3

[Micah Dubinko]

Attachment: simple test case

Comment 4

[Micah Dubinko]

Tried on 19990929 nightly build, Windows98. Marked All/All.

Comment 5

[Brendan Eich [:brendan]]

I have this almost fixed in my tree, getting in for M11.

/be

Comment 6

[Chris Petersen]

With the Nov 15 Mac build (1999111508), I get a crash when attempting to open the
simple test case. On Win32 or Linux Nov 15th build, the loads in the browser but
doesn't crash. Reopening the bug because the crash on the Mac build.

Comment 7

[Brendan Eich [:brendan]]

I have no Mac -- can a Mac buddy (I'm cc'ing a few) run the test case and tell
me the stack and file/line of the crash?  Thanks,

/be

Comment 8

[leger]

Clearing FIXED resolution due to reopen.  petersen, can you get a stack trace?

Comment 9

[Simon Fraser [no longer active]]

Here's the crash stack for Mac:

 Calling chain using A6/R1 links
  Back chain  ISA  Caller
  00000000    PPC  06EB89F0
  07A90400    PPC  06EB41E8  main+0019C
  07A90370    PPC  06EB2A4C  main1(int, char**)+005F4
  07A90290    PPC  0AE55848  nsAppShellService::Run()+000BC
  07A90240    PPC  0AB0CD60  nsAppShell::Run()+00050
  07A901C0    PPC  0AB0D660  nsMacMessagePump::DoMessagePump()+00044
  07A90170    PPC  0AB0DD9C  nsMacMessagePump::DispatchEvent(int, EventRecord*)+
0039C
  07A90110    PPC  0E86E7FC  Repeater::DoRepeaters(const EventRecord&)+00034
  07A900D0    PPC  0AAE9294  nsMacNSPREventQueueHandler::RepeatAction(const
EventRecord&)+000
D0
  07A90080    PPC  0AD06670  nsEventQueueImpl::HandleEvent(PLEvent*)+00014
  07A90040    PPC  0BF303C0  PL_HandleEvent+0004C
  07A90000    PPC  0AE21D80  nsStreamListenerEvent::HandlePLEvent(PLEvent*)+00060
  07A8FFB0    PPC  0AE22EEC  nsOnDataAvailableEvent::HandleEvent()+00080
  07A8FF60    PPC  0B97CF44  nsFileChannel::OnDataAvailable(nsIChannel*,
nsISupports*, nsIInp
utStream*, unsigned int, unsigned int)+0010C
  07A8FF10    PPC  0B98FD04  nsChannelListener::OnDataAvailable(nsIChannel*,
nsISupports*, ns
IInputStream*, unsigned int, unsigned int)+00084
  07A8FEC0    PPC  0B98DD48  nsDocumentBindInfo::OnDataAvailable(nsIChannel*,
nsISupports*, n
sIInputStream*, unsigned int, unsigned int)+00120
  07A8FE50    PPC  0A95B97C  nsParser::OnDataAvailable(nsIChannel*, nsISupports*,
nsIInputStr
eam*, unsigned int, unsigned int)+00364
  07A8FD40    PPC  0A95AB18  nsParser::ResumeParse(nsIDTD*, int)+00144
  07A8FCE0    PPC  0A95ADFC  nsParser::BuildModel()+00110
  07A8FC80    PPC  0A9493C4  CNavDTD::BuildModel(nsIParser*, nsITokenizer*,
nsITokenObserver*
, nsIContentSink*)+000F0
  07A8FC20    PPC  0A949934  CNavDTD::HandleToken(CToken*, nsIParser*)+00284
  07A8FBC0    PPC  0A94ACF8  CNavDTD::HandleStartToken(CToken*)+002E8
  07A8FB60    PPC  0A94A25C  CNavDTD::HandleDefaultStartToken(CToken*, nsHTMLTag,
nsIParserNo
de*)+002C0
  07A8FAF0    PPC  0A94DB98  CNavDTD::OpenContainer(const nsIParserNode*,
nsHTMLTag, int, int
)+001E8
  07A8FAA0    PPC  0A94BCDC  CNavDTD::HandleScriptToken(const nsIParserNode*)+
00020
  07A8FA60    PPC  0A94E1A4  CNavDTD::AddLeaf(const nsIParserNode*)+0005C
  07A8F950    PPC  06ACDF50  HTMLContentSink::AddLeaf(const nsIParserNode&)+0015C
  07A8F8F0    PPC  06AD2760  HTMLContentSink::ProcessSCRIPTTag(const
nsIParserNode&)+009C4
  07A8F3D0    PPC  06AD1870  HTMLContentSink::EvaluateScript(nsString&, int,
const char*)+001
88
  07A8F2C0    PPC  0AB462DC  nsJSContext::EvaluateString(const nsString&, void*,
nsIPrincipal
*, const char*, unsigned int, const char*, nsString&, int*)+00774
  07A8F1D0    PPC  0AD1D0FC  nsString::Assign(const unsigned short*, int)+00044
 Closing log

Comment 10

[Brendan Eich [:brendan]]

I crave line numbers.  Any Mac buddies able to get those?

/be

Comment 11

[Simon Fraser [no longer active]]

Wimp!

nsJSEnvironment.cpp:240 looks like:

      aRetValue.SetString(JS_GetStringChars(jsstring));

the call to JS_GetStringChars(jsstring) is returning a bad address. It looks like
jsstring points into lala land at this point. 'val' doesn't look too good either.

Comment 12

[Brendan Eich [:brendan]]

Fixed, for sure.  Thanks to sfraser for help -- and what kind of Mac should I
get if I want a personal Mac that runs CW and Mozilla well?  Don't say iBook!

/be

Comment 13

[Simon Fraser [no longer active]]

You can't go much wrong with a G3/450, or a G4 if you want the cutting edge.
sdagley has a G4 if you want to consult.

Comment 14

[Chris Petersen]

Yippee ! The crash has been fixed on the Mac Nov 16th build (1999111608). Marking
as verified fixed.

Comment 15

[Steve Dagley]

Go for the G4/450.  The faster bus (double the throughput capability of the G3)

and ATA/66 support let the standard machine build about as fast as the G3/450

with a SCSI RAID.