1316753 - Now that there is a cZ 0.9.93 at AMO, the $CHATZILLA_VERSION in distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi should be upped to at least that value to avoid auto-downgrade by about:addons

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Tony Mechelynck [:tonymec]]

UA:"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49a1" 
ID:20161110003001 en-US 
c-c:5cb6c4f805a525ffda697c35221af3612f4cccf3 
m-c:336759fad4621dfcd0a3293840edbed67018accd

There was a new ChatZilla at AMO on November 9 (i.e. before this nightly was built) with version number 0.9.93.

INSTALLDIR/distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi::install.rdf is still at version 0.9.92. If we don't make it higher, about:addons will install the AMO version in preference to the distributed version, which (in trunk builds of SeaMonkey) is always built from the head of the default branch of the cZ hg repo. There would thus occur an auto-downgrade which we want to avoid.

Aurora and older branches of SeaMonkey ought to be unaffected… as long as tag SEA_2_42_RELBRANCH is at an older changeset than the one used to build cZ 0.9.93 for upload at AMO.

Gijs, Silver: The latest cZ nightly is http://james-ross.co.uk/mozilla/chatzilla/nightly/builds/0.9.92/2016110821/. I suppose a 0.9.93 subdir should be created for the next cZ nightly when there is one, but this is your pidgin.

Comment 1

[James Ross]

I have been unable to push the version bump when I wanted because Mozilla disabled my Mercurial account yet again, and that bug hasn't been resolved yet, despite being assigned since 48 hours ago. I'll push the changes as soon as their policy stops getting in the way. :)

Comment 2

[Tony Mechelynck [:tonymec]]

(In reply to James Ross from comment #1)
> I have been unable to push the version bump when I wanted because Mozilla
> disabled my Mercurial account yet again, and that bug hasn't been resolved
> yet, despite being assigned since 48 hours ago. I'll push the changes as
> soon as their policy stops getting in the way. :)

Disabled your access to https://hg.mozilla.org/chatzilla/ ? Or to comm-central? So not only they have a policy from on high that "helping SeaMonkey on company time, be it by moving a little finger, is forbidden by company policy", they are definitely throwing wrenches into our cogwheels and breaking whatever they can! Lets hope the snafu gets straightened out asap. :-/

Comment 3

[:Gijs (he/him)]

(In reply to Tony Mechelynck [:tonymec] from comment #2)
> (In reply to James Ross from comment #1)
> > I have been unable to push the version bump when I wanted because Mozilla
> > disabled my Mercurial account yet again, and that bug hasn't been resolved
> > yet, despite being assigned since 48 hours ago. I'll push the changes as
> > soon as their policy stops getting in the way. :)
> 
> Disabled your access to https://hg.mozilla.org/chatzilla/ ? Or to
> comm-central? So not only they have a policy from on high that "helping
> SeaMonkey on company time, be it by moving a little finger, is forbidden by
> company policy", they are definitely throwing wrenches into our cogwheels
> and breaking whatever they can! Lets hope the snafu gets straightened out
> asap. :-/

This won't really be an intentional throwing of wrenches, just an automated thing that removes access to hg.m.o if unused for timperiod N, which is a security practice they implement for everyone, not just to annoy seamonkey folks... Anyway, I can land this in a few hours if someone has a patch I can use?

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1316753-cz-version.patch

If the 0.9.93 was build with the latest changes in the tree this patch should be all what is needed I set the maxversion in the xpi make to the current -central versions. The add-on code no longer checks this for the xpi but would do it for a language pack.

Comment 5

[James Ross]

@Tony, like Gijs says it wasn't intentionally causing problems, just a policy tuned such that it makes it annoying to be a part-time contributor. Not sure why it took 73 hours to re-enable but it's done now, here's ChatZilla 0.9.93:

https://hg.mozilla.org/chatzilla/rev/b122e17dfeda5320e76e13df2238519855cde797

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8810115 [details] [diff] [review]
1316753-cz-version.patch

Looks good. Thanks for the update.

Comment 7

[Tony Mechelynck [:tonymec]]

(In reply to Frank-Rainer Grahl from comment #4)
> Created attachment 8810115 [details] [diff] [review]
> 1316753-cz-version.patch
> 
> If the 0.9.93 was build with the latest changes in the tree this patch
> should be all what is needed I set the maxversion in the xpi make to the
> current -central versions. The add-on code no longer checks this for the xpi
> but would do it for a language pack.

The addons manager code checks the _extension_ version in install.rdf when deciding whether or not to download and install an update from AMO, which is what this bug is about. What it no longer checks (unless the add-on requires it, like e.g. Lightning does) is the _application_ maxVersion (also defined in the addon's install.rdf) where the add-on may be installed.

Alas, the latest SeaMonkey 2.49a1 nightly has a build ID of 20161112060709 which is earlier than comment #5 so I cannot yet VERIFY this bugfix. I'll check the extension version in the INSTALLDIR/distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi::install.rdf after installing the 2016-11-13 nightly once it is built. In the meantime I have installed ChatZilla nightly 0.9.93.2016111219 so about:addons won't bug me about a cZ 0.9.93 update anymore.

Comment 8

[Tony Mechelynck [:tonymec]]

UA:"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49a1" 
ID:20161113003001 en-US 
c-c:330fade4b94b549426eed14f6f9b44f65b7ef858 
m-c:b37be3d705d929ee52280051d58cedc70a47626f

  <Description about="urn:mozilla:install-manifest">
    <!-- core data -->
    <em:id>{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}</em:id>
    <em:version>0.9.93</em:version>
    <em:type>2</em:type>

cZ version is now 0.9.93 in distribution/extensions => VERIFIED.