1316851 - Refactor Firefox UI tests to directly use MarionetteTestCase and PuppeteerMixin

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Next step to for our tests should be to use the MarionetteTestCase class directly, and if necessary also the PuppeteerMixin class.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1316851 - Firefox UI tests have to use super() to call base class methods.

Review commit: https://reviewboard.mozilla.org/r/92304/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92304/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1316851 - Firefox UI harness has to use super() to call base class methods.

Review commit: https://reviewboard.mozilla.org/r/92306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92306/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1316851 - Puppeteer has to use super() to call base class methods.

Review commit: https://reviewboard.mozilla.org/r/92308/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92308/

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1316851 - Testcases should directly inherit from MarionetteTestCase and PuppeteerMixin.

Review commit: https://reviewboard.mozilla.org/r/92310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92310/

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8809795 [details]
Bug 1316851 - Testcases should directly inherit from MarionetteTestCase and PuppeteerMixin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92310/diff/1-2/

Comment 6

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8809792 [details]
Bug 1316851 - Firefox UI tests have to use super() to call base class methods.

https://reviewboard.mozilla.org/r/92304/#review92432

Comment 7

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8809793 [details]
Bug 1316851 - Firefox UI harness has to use super() to call base class methods.

https://reviewboard.mozilla.org/r/92306/#review92434

Comment 8

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8809794 [details]
Bug 1316851 - Puppeteer has to use super() to call base class methods.

https://reviewboard.mozilla.org/r/92308/#review92436

Comment 9

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8809795 [details]
Bug 1316851 - Testcases should directly inherit from MarionetteTestCase and PuppeteerMixin.

https://reviewboard.mozilla.org/r/92310/#review92438

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd498d1a4490
Firefox UI tests have to use super() to call base class methods. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/ad8f42a8e7f6
Firefox UI harness has to use super() to call base class methods. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/608cebbca5c4
Puppeteer has to use super() to call base class methods. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/af0d5a28645e
Testcases should directly inherit from MarionetteTestCase and PuppeteerMixin. r=maja_zf

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cd498d1a4490
https://hg.mozilla.org/mozilla-central/rev/ad8f42a8e7f6
https://hg.mozilla.org/mozilla-central/rev/608cebbca5c4
https://hg.mozilla.org/mozilla-central/rev/af0d5a28645e