1316880 - Parsing a .ini file with Windows line endings returns Junk

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: compare-locales, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: updater.ini

It happened with the attached file while testing the l20n migration script.

The .val I get for Junk is _junk_8_247-248, haven't checked if the rest of the file is read properly

Comment 1

[Francesco Lodolo [:flod]]

Looking at the output of the Transvision testing branch, it reads the values, with a weird new line at the end

'suite/updater/updater.ini:InfoText' => '%MOZ_APP_DISPLAYNAME% sta installando gli aggiornamenti e si avvierà fra qualche istante…
',

'suite/updater/updater.ini:TitleText' => 'Aggiornamento %MOZ_APP_DISPLAYNAME%
',

Comment 2

[Axel Hecht [:Pike]]

Attachment: bug 1316880, make line-ending handling universal universially,

Some code-parts use universal line endings, some didn't.
Make that consistent.

Review commit: https://reviewboard.mozilla.org/r/92380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92380/

Comment 3

[Francesco Lodolo [:flod]]

Comment on attachment 8809880 [details]
bug 1316880, make line-ending handling universal universially,

https://reviewboard.mozilla.org/r/92380/#review92406

Thanks, it works great. Only nit: typo in the commit message ;-)

Comment 4

[Axel Hecht [:Pike]]

https://hg.mozilla.org/l10n/compare-locales/rev/bc436e6748c408fde110a6de5952d19c1478fc33, FIXED.

Also edited the commit message.