1317180 - Remove some cruft from IPDL parser

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

MessageId has the production "'~' ID", but if you use it, it produces an error: "sorry, `%s()' destructor syntax is a relic from a bygone era.  Declare `__delete__()' in the `%s' protocol instead". This warning message was added in 2009, in bug 525342, so I doubt anybody expects it to work any more, so it should just be a regular parse error.

Comment 1

[Andrew McCreight [:mccr8]]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3114604ce39331ab9277d951da3a8fd39e824402

There are a number of patches here, but they should all be simple.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1317180, part 1 - Remove trailing whitespace from ast.py and parser.py.

Review commit: https://reviewboard.mozilla.org/r/92884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92884/

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1317180, part 2 - Remove really old ~ syntax error for MessageId in IPDL parser.

MessageId has the production "'~' ID", but if you use it, it produces
an error. This error was added in 2009, in bug 525342. I doubt anybody
expects it to work any more, so it should just be a regular parse
error. This is the only usage of the literal ~ so it can now be
removed from there.

Review commit: https://reviewboard.mozilla.org/r/92886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92886/

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1317180, part 3 - Remove unused ActorType syntax.

Review commit: https://reviewboard.mozilla.org/r/92888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92888/

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Bug 1317180, part 4 - Inline ScalarType.

Review commit: https://reviewboard.mozilla.org/r/92890/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92890/

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: Bug 1317180, part 5 - Get rid of the now-unused state field in TypeSpec.

Review commit: https://reviewboard.mozilla.org/r/92892/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92892/

Comment 7

[Andrew McCreight [:mccr8]]

Attachment: Bug 1317180, part 6 - Removed some unused arguments from TypeSpec ctor.

Review commit: https://reviewboard.mozilla.org/r/92894/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92894/

Comment 8

[Andrew McCreight [:mccr8]]

Attachment: Bug 1317180, part 7 - Remove TypeSpec fields myChmod and otherChmod that are never set.

The other fields, spec, array, and nullable, are set in some places.

Also remove a dead chunk of code with a FIXME that refers to a bug
that was WONTFIXed in 2010.

Review commit: https://reviewboard.mozilla.org/r/92896/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92896/

Comment 9

[Andrew McCreight [:mccr8]]

Attachment: Bug 1317180, part 8 - Remove unused optional argument chmodallowed to _canonicalType.

As of the previous patch, this argument no longer does anything.

Review commit: https://reviewboard.mozilla.org/r/92898/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92898/

Comment 10

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8810599 [details]
Bug 1317180, part 1 - Remove trailing whitespace from ast.py and parser.py.

https://reviewboard.mozilla.org/r/92884/#review92894

Comment 11

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8810600 [details]
Bug 1317180, part 2 - Remove really old ~ syntax error for MessageId in IPDL parser.

https://reviewboard.mozilla.org/r/92886/#review92896

Comment 12

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8810601 [details]
Bug 1317180, part 3 - Remove unused ActorType syntax.

https://reviewboard.mozilla.org/r/92888/#review92898

Comment 13

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8810602 [details]
Bug 1317180, part 4 - Inline ScalarType.

https://reviewboard.mozilla.org/r/92890/#review92902

Comment 14

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8810603 [details]
Bug 1317180, part 5 - Get rid of the now-unused state field in TypeSpec.

https://reviewboard.mozilla.org/r/92892/#review92904

Comment 15

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8810604 [details]
Bug 1317180, part 6 - Removed some unused arguments from TypeSpec ctor.

https://reviewboard.mozilla.org/r/92894/#review92906

Comment 16

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8810605 [details]
Bug 1317180, part 7 - Remove TypeSpec fields myChmod and otherChmod that are never set.

https://reviewboard.mozilla.org/r/92896/#review92908

Comment 17

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8810606 [details]
Bug 1317180, part 8 - Remove unused optional argument chmodallowed to _canonicalType.

https://reviewboard.mozilla.org/r/92898/#review92910

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46626bec2598
part 1 - Remove trailing whitespace from ast.py and parser.py. r=billm
https://hg.mozilla.org/integration/autoland/rev/a8b85a9b7092
part 2 - Remove really old ~ syntax error for MessageId in IPDL parser. r=billm
https://hg.mozilla.org/integration/autoland/rev/04d44b806d48
part 3 - Remove unused ActorType syntax. r=billm
https://hg.mozilla.org/integration/autoland/rev/67e266ee225a
part 4 - Inline ScalarType. r=billm
https://hg.mozilla.org/integration/autoland/rev/e7059b65e7aa
part 5 - Get rid of the now-unused state field in TypeSpec. r=billm
https://hg.mozilla.org/integration/autoland/rev/9c02838f29ec
part 6 - Removed some unused arguments from TypeSpec ctor. r=billm
https://hg.mozilla.org/integration/autoland/rev/0dea817804ac
part 7 - Remove TypeSpec fields myChmod and otherChmod that are never set. r=billm
https://hg.mozilla.org/integration/autoland/rev/b7ccea321333
part 8 - Remove unused optional argument chmodallowed to _canonicalType. r=billm

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46626bec2598
https://hg.mozilla.org/mozilla-central/rev/a8b85a9b7092
https://hg.mozilla.org/mozilla-central/rev/04d44b806d48
https://hg.mozilla.org/mozilla-central/rev/67e266ee225a
https://hg.mozilla.org/mozilla-central/rev/e7059b65e7aa
https://hg.mozilla.org/mozilla-central/rev/9c02838f29ec
https://hg.mozilla.org/mozilla-central/rev/0dea817804ac
https://hg.mozilla.org/mozilla-central/rev/b7ccea321333