1317243 - aboutPrivateBrowsing.note.before has a trailing non-breaking whitespace, causing redundant ending whitespace in about:privatebrowsing

Status: RESOLVED FIXED

(Mozilla Localizations :: cs / Czech, defect)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

When you open new anonymous window, the text describing what it can and cannot do contains two spaces between aboutPrivateBrowsing.note.before and aboutPrivateBrowsing.note.emphasize. The space at the end of aboutPrivateBrowsing.note.before is either redundant, or there is a space being added in the code itself. Not sure, what's the right solution, as some localizers might notice and fix by removing the space from their translation.

Comment 1

[Axel Hecht [:Pike]]

Moving over to fx/private browsing, as this is about the code in question much more than about l10n.

Comment 2

[Francesco Lodolo [:flod]]

I'm not sure I understand the problem.

This is how my DTD looks like

<!ENTITY aboutPrivateBrowsing.note.before "La navigazione anonima ">
<!ENTITY aboutPrivateBrowsing.note.emphasize "non nasconde ogni traccia della navigazione">
<!ENTITY aboutPrivateBrowsing.note.after " su Internet. Il datore di lavoro o il fornitore di servizi internet saranno comunque in grado di mantenere un registro delle pagine visitate.">

And this the resulting HTML in Firefox
<p>
La navigazione anonima 
<strong>non nasconde ogni traccia della navigazione</strong>
su Internet. Il datore di lavoro o il fornitore di servizi internet saranno comunque in grado di mantenere un registro delle pagine visitate.
</p>
        
I can only see one space displayed, as expected in a HTML page.

Comment 3

[Francesco Lodolo [:flod]]

This is the code of the page
https://dxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml#57

We could argue that the trailing space is not actually needed, since the new line in the code introduces a whitespace, but I don't see two spaces and I think it makes sense to have it in the string in case the structure changes.

Comment 4

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: screenshot (Nightly 53.0a1)

Well, at least in Czech is does not work. In the source I see this: 

        <p>
          &aboutPrivateBrowsing.note.before;
          <strong>&aboutPrivateBrowsing.note.emphasize;</strong>
          &aboutPrivateBrowsing.note.after;
        </p>

And if I try to highlight the text with my mouse, I see two spaces there. It's even visible on the screenshot (Anonymní prohlížení  vás na internetu neudělá...). As for the localization, we follow spaced as there are in the original.

Comment 5

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Interesting the double space is not after the <strong> text, as aboutPrivateBrowsing.note.after starts with a space for change.

Comment 6

[Francesco Lodolo [:flod]]

Can you inspect the page with Developer Tools and see how the paragraph looks like?

Italian on OS X, and English in Linux look normal, with the same spacing.

Comment 7

[Francesco Lodolo [:flod]]

Ah, figured it out. You have a non breaking space in .before, not a standard space, that's why it happens.

Comment 8

[Francesco Lodolo [:flod]]

Let's move it back to Czech component, since it can be fixed in the localization.

Comment 9

[Axel Hecht [:Pike]]

Or is this a pontoon bug? Matjaz?

Comment 10

[Francesco Lodolo [:flod]]

Looks like there are a few locales with a non breaking whitespace (gray square)
https://transvision.mozfr.org/string/?entity=browser/chrome/browser/aboutPrivateBrowsing.dtd:aboutPrivateBrowsing.note.before&repo=aurora

It seems unlikely that all locales added it on purpose.

Comment 11

[Francesco Lodolo [:flod]]

Per IRC discussion with Pike, we should still fix the XHTML file and avoid introducing unnecessary whitespaces.

I'm going to file a follow-up for that.

Comment 12

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Seems you are right. I have replaced it with a regular space in Pontoon now. Before I have clicked the placeholder in Pontoon, so probably that's a Pontoon issue.

Should I close this bug in Czech component once the change is committed and I can verify in Nightly, or should I wait until the code is fixed too?

Comment 13

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

https://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/559c0df129a7

Comment 14

[Matjaz Horvat [:mathjazz]]

Confirming there's a bug in Pontoon.

PR waiting for a review.

Thanks for reporting!

Comment 15

[[github robot]]

Commits pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/e95ed237e88d1477600a31fa9f5faf1b0ce55005
Bug 1317243: Do not replace space with  

https://github.com/mozilla/pontoon/commit/b632cb1e23ed5ac00f36ec3b5f4f4648e3319736
Bug 1317243: Do not replace space with   (#500)

Comment 16

[Francesco Lodolo [:flod]]

(In reply to Michal Stanke (Mozilla.cz) [:MikkCZ] from comment #12)
> Should I close this bug in Czech component once the change is committed and
> I can verify in Nightly, or should I wait until the code is fixed too?
Once you verify it in a build, it's OK. Fixing bug 1317438 will not change the result.