1317359 - Android beta 51 builds fail with "Must specify --with-adjust-sdk-keyfile when MOZ_INSTALL_TRACKING is defined!"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Carsten Book [:Tomcat]]

No idea if this is a real problem or intermittent but https://treeherder.mozilla.org/logviewer.html#?job_id=1916768&repo=mozilla-beta fails now 3 times in a row.

Comment 1

[Carsten Book [:Tomcat]]

Callek, can you take a look if this is merge day related, thanks!

Comment 2

[Justin Wood (:Callek)]

This shouldn't be using hg unbundle (well I'm not sure why, but we should just be using robustcheckout instead)  Its also not fatal in terms of hg ubundling due to the "falling back to clone"

 Trying to use bundle https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/bundles/mozilla-beta.hg
 command: START
 command: hg unbundle --traceback https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/bundles/mozilla-beta.hg
 command: cwd: /builds/hg-shared/releases/mozilla-beta
 command: env: {'HGPLAIN': '1'}
 Hit exception running hg:
 Traceback (most recent call last):
   File "/builds/slave/m-beta-and-api-15-000000000000/tools/buildfarm/utils/../../lib/python/util/hg.py", line 99, in get_hg_output
     return get_output(['hg'] + cmd, timeout=timeout, env=env, **kwargs)
   File "/builds/slave/m-beta-and-api-15-000000000000/tools/buildfarm/utils/../../lib/python/util/commands.py", line 207, in get_output
     raise error
 CalledProcessError: Command '['hg', 'unbundle', '--traceback', 'https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/bundles/mozilla-beta.hg']' returned non-zero exit status 255
Using bundles failed; falling back to clone

Comment 3

[Justin Wood (:Callek)]

Real error is later on with ""DEBUG: configure: error: Must specify --with-adjust-sdk-keyfile when MOZ_INSTALL_TRACKING is defined!""

Comment 4

[Justin Wood (:Callek)]

:glandium, you were the one to move these keyfiles to python configure, can you investigate this beta-only fallout?

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1317359 - Move add_old_configure_* functions to util.configure.

Review commit: https://reviewboard.mozilla.org/r/92902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92902/

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8810611 [details]
Bug 1317359 - Move add_old_configure_* functions to util.configure.

https://reviewboard.mozilla.org/r/92902/#review92858

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c403ebdab6b8
Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for build failures like https://treeherder.mozilla.org/logviewer.html#?job_id=6625338&repo=autoland

https://hg.mozilla.org/integration/autoland/rev/7b16a8d86a69eaf7f21ad80f9894fc589798045b

Comment 9

[Mike Hommey [:glandium]]

That's what you get for not amending a commit before pushing.

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 8810611 [details]
Bug 1317359 - Move add_old_configure_* functions to util.configure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92902/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d6366a2842e
Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester

Comment 12

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/ec87fff279b6c9481ee9c18beeed3fcfc658c46d for test_checks_configure.py bustage, https://treeherder.mozilla.org/logviewer.html#?job_id=6631250&repo=autoland

Comment 13

[Mike Hommey [:glandium]]

Attachment: Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure.

Review commit: https://reviewboard.mozilla.org/r/93032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93032/

Comment 14

[Mike Hommey [:glandium]]

Comment on attachment 8810611 [details]
Bug 1317359 - Move add_old_configure_* functions to util.configure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92902/diff/2-3/

Comment 15

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8810611 [details]
Bug 1317359 - Move add_old_configure_* functions to util.configure.

https://reviewboard.mozilla.org/r/92902/#review93280

Comment 16

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8810724 [details]
Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure.

https://reviewboard.mozilla.org/r/93032/#review93282

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/387015ba9c74
Move add_old_configure_* functions to util.configure. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/40935ab99b85
Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester

Comment 18

[Rail Aliiev [:rail]]

pushed to beta to unblock b1: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=f4f4fce526f54e4d4339fc6e5d87320df6126da6

Comment 19

[Rail Aliiev [:rail]]

Still need to uplift to aurora

Comment 20

[Mike Hommey [:glandium]]

Comment on attachment 8810724 [details]
Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure.

(Note this is post-facto for beta)

Approval Request Comment
[Feature/regressing bug #]: Regression from bug 1294585 only affecting android beta
[User impact if declined]: Can't build beta (IOW, 52 will fail to build when it reaches beta ; 51 failed to build when it reached beta).
[Describe test coverage new/current, TreeHerder]: The bug breaks running configure, so configure passing, and existing unit tests not failing is how we know this fixes the issue.
[Risks and why]: Low, cf. above.
[String/UUID change made/needed]: None

BTW: this should have been caught by {central,aurora}-as-beta pushes to try, haven't there been any?

Comment 21

[Mike Hommey [:glandium]]

Note I'm only flagging one patch, for convenience, but both patches are required.

Comment 22

[Julien Cristau [:jcristau]]

Comment on attachment 8810611 [details]
Bug 1317359 - Move add_old_configure_* functions to util.configure.

fix fennec build on beta, uplift to 51 and 52

Comment 23

[Julien Cristau [:jcristau]]

Comment on attachment 8810724 [details]
Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure.

fix fennec build on beta, uplift to 51 and 52 (this one already landed on beta)

Comment 24

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8810611 [details]
Bug 1317359 - Move add_old_configure_* functions to util.configure.

I pushed this to beta to fix the bustage from only 1 part landing:
https://hg.mozilla.org/releases/mozilla-beta/rev/749a8d32b74eae516b9427f28aad4ec1c11e0a54

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/387015ba9c74
https://hg.mozilla.org/mozilla-central/rev/40935ab99b85

Comment 26

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/03d26fc3da00
https://hg.mozilla.org/releases/mozilla-aurora/rev/1a240efc72a9

Comment 27

[Carsten Book [:Tomcat]]

has problems to apply to beta

warning: conflicts while merging build/moz.configure/util.configure! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 28

[Mike Hommey [:glandium]]

It's already on beta, cf. comment 18 and comment 24

Comment 29

[Carsten Book [:Tomcat]]

(In reply to Mike Hommey [:glandium] from comment #28)
> It's already on beta, cf. comment 18 and comment 24

oh right setting flags then