1317504 - Move LD to python configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1317504 - Warn that LD is not used by the build system.

It turns out that, in practice, the LD variable is not used by the build
system, except on Windows, where it's used to feed the default for LINK,
which is then re-injected as LD.

The upcoming changes are going to normalize the use of LD/LINK.

Review commit: https://reviewboard.mozilla.org/r/95310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95310/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1317504 - Remove unused non-GCC/clang flags settings.

Compilers other than GCC, clang and MSVC have not been supported for a
while, and have been explicitly rejected since bug 1259382.

There are a few branches in old-configure that are taken for
non-GCC/clang compilers, but all of them are later overwritten by the
MSVC setup. So we just remove those.

Review commit: https://reviewboard.mozilla.org/r/95312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95312/

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1317504 - Remove the GNU_LD variable, nothing uses it.

Review commit: https://reviewboard.mozilla.org/r/95314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95314/

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1317504 - Make MSVC builds use the LINK variable instead of LD.

At the same time, remove HOST_LD. It was only used for MSVC builds,
which don't support cross-compile anyways, so we can, at least for now,
use LINK for both host and target.

Review commit: https://reviewboard.mozilla.org/r/95316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95316/

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1317504 - Don't try to set LD from old-configure.

Now, it's completely unused.

Review commit: https://reviewboard.mozilla.org/r/95318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95318/

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8814016 [details]
Bug 1317504 - Warn that LD is not used by the build system.

https://reviewboard.mozilla.org/r/95310/#review96518

Comment 7

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8814017 [details]
Bug 1317504 - Remove unused non-GCC/clang flags settings.

https://reviewboard.mozilla.org/r/95312/#review96522

Comment 8

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8814018 [details]
Bug 1317504 - Remove the GNU_LD variable, nothing uses it.

https://reviewboard.mozilla.org/r/95314/#review96532

Comment 9

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8814019 [details]
Bug 1317504 - Make MSVC builds use the LINK variable instead of LD.

https://reviewboard.mozilla.org/r/95316/#review96534

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8814020 [details]
Bug 1317504 - Don't try to set LD from old-configure.

https://reviewboard.mozilla.org/r/95318/#review96536

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cffe1cd111f6
Warn that LD is not used by the build system. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/677f47fec9e7
Remove unused non-GCC/clang flags settings. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/fd007caf51df
Remove the GNU_LD variable, nothing uses it. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/6353e704bf2c
Make MSVC builds use the LINK variable instead of LD. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/8c1409a443ee
Don't try to set LD from old-configure. r=chmanchester

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cffe1cd111f6
https://hg.mozilla.org/mozilla-central/rev/677f47fec9e7
https://hg.mozilla.org/mozilla-central/rev/fd007caf51df
https://hg.mozilla.org/mozilla-central/rev/6353e704bf2c
https://hg.mozilla.org/mozilla-central/rev/8c1409a443ee