1317706 - Remove Pose WebIDL because we can move the sharing implementation to our c++ code

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daosheng Mu[:daoshengmu]]

As the discussion at Bug 1299932 Comment 68, we can share the implementation instead of sharing in Pose IDL, and it would make more sense for following the relevant specs.

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1317706 - Removing Pose WebIDL

:bz, could you help me review this patch or I should ask for someone else because you don't accept for review currently.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8810891 [details] [diff] [review]
Bug 1317706 - Removing Pose WebIDL

You don't need to declare Pose::WrapObject at all.

r=me with that removed.

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1317706 - Removing Pose WebIDL (v2)

V2:
Follow Comment 2 to remove Pose::WrapObject and carry the r+.

Comment 4

[Daosheng Mu[:daoshengmu]]

Please help land Attachment #8811081 [details] [diff] to m-c

Try looks good.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=65176892846241cc20e14e104be4936261504977

Comment 5

[Carsten Book [:Tomcat]]

has conflicts to apply:

1 out of 1 hunks FAILED -- saving rejects to file dom/webidl/moz.build.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1317706-Removing-Pose-WebIDL-for-sharing-the-imp.patch

Comment 6

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1317706 - Removing Pose WebIDL (v3)

Carry r+ from Comment 2 and according to Comment 5 to rebase to fix conflict.

Comment 7

[Daosheng Mu[:daoshengmu]]

I have done the rebase with the latest m-c source code, but I don't see any conflict.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5020b7acf45
Remove Pose WebIDL for sharing the implementation to Pose class. r=bz

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d5020b7acf45

Comment 10

[areya]

https://hg.mozilla.org/mozilla-central/rev/d5020b7acf45

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8811739 [details] [diff] [review]
Bug 1317706 - Removing Pose WebIDL (v3)

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1299932
[User impact if declined]: shipping something we shouldn't be to release users (see bug 1332614)
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just un-shipping something we don't want to ship.
[String changes made/needed]: None

Comment 12

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8811739 [details] [diff] [review]
Bug 1317706 - Removing Pose WebIDL (v3)

remove pose webidl, aurora52+

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/970562d09078