1318044 - BUILDSTATUS messages printed when building with clang + color

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

This is a regression from bug 1171610.

When building with Clang with color enabled, sometimes the output contains "BUILDSTATUS *" messages. These messages are supposed to be slurped away by the build output monitor running in the mach process. However, that isn't working. The likely culprit is terminal control bytes related to coloring.

As was observed in the development of bug 1171610, Clang doesn't "unset" its control codes at the end of every line (GCC does). I thought this was limited to the mach time prefixes being colored incorrectly. I guess it is interfering with BUILDSTATUS output parsing as well :/

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot

(In reply to Gregory Szorc [:gps] from comment #0)
> Clang doesn't "unset" its
> control codes at the end of every line (GCC does).

This is likely also why I see timestamps showing up "brighter" occasionally (see attached screenshot).

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1318044 - Issue sgr0 after printing every line;

The sgr0 terminal capabity defines the byte sequence needed to reset
terminal text to its default state. For reasons documented inline in
this commit, we now print this sequence after every line printed by
mach's terminal logger.

Review commit: https://reviewboard.mozilla.org/r/98170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98170/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8818050 [details]
Bug 1318044 - Issue sgr0 after printing every line;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98170/diff/1-2/

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8818050 [details]
Bug 1318044 - Issue sgr0 after printing every line;

https://reviewboard.mozilla.org/r/98170/#review99962

WFM!

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8818050 [details]
Bug 1318044 - Issue sgr0 after printing every line;

Flip glandium's r+ flag, since mozreview didn't notice my r+.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b0dd252edd7
Issue sgr0 after printing every line; r=froydnj

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3b0dd252edd7