Closed
Bug 1318189
Opened 8 years ago
Closed 8 years ago
./mach configure doesn't detect MFC when using VS15 preview / 2017
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
()
Details
Attachments
(1 file)
Directory structure is changed from VS15(2017) Preview. So we don't detect MFC correctly.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → m_kato
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8812652 [details] Bug 1318189 - mach configure cannot detect MFC library path on VS2017. https://reviewboard.mozilla.org/r/94310/#review95162 ::: build/moz.configure/windows.configure:342 (Diff revision 1) > if not os.path.isdir(atlmfc_dir): > - die('Cannot find the ATL/MFC libraries in the Visual C++ directory (%s). ' > - 'Please install them.' % vc_path) > + # For Visual Studio 2017 > + atlmfc_dir = os.path.join(vc_path, 'atlmfc', 'lib', sdk_target) > + if not os.path.isdir(atlmfc_dir): > + die('Cannot find the ATL/MFC libraries in the Visual C++ directory' > + ' (%s). Please install them.' % vc_path) Please move the space to the end of previous line.
Attachment #8812652 -
Flags: review?(mh+mozilla) → review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/mozilla-inbound/rev/53a9ff4a083a mach configure cannot detect MFC library path on VS2017. r=glandium
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/53a9ff4a083a
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•