1318493 - Tell the eslint parser to use ecmaVersion 8

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

eslint currently fails on the shiny new "async" and "await" commands. The solution appears to be to add:

  "parserOptions": {
    "ecmaVersion": 8,
  },

to the eslintrc.js file. Mossop suggested I just stick it in the root.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1318493 - Tell the eslint parser to use ecmaVersion 8.

Review commit: https://reviewboard.mozilla.org/r/93854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93854/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8811960 [details]
Bug 1318493 - Tell the eslint parser to use ecmaVersion 8.

https://reviewboard.mozilla.org/r/93854/#review94362

::: .eslintrc.js:14
(Diff revision 1)
>      "mozilla/import-globals": "warn",
>    },
>    "env": {
>      "es6": true
>    },
> +"parserOptions": {

Fix the indentation here please.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8811960 [details]
Bug 1318493 - Tell the eslint parser to use ecmaVersion 8.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93854/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/590858b739ab
Tell the eslint parser to use ecmaVersion 8. r=mossop

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/590858b739ab