1318903 - [Windows 7 and below] Fullscreen window controls not shown with dark themes, close button has broken "red square" hover state

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Yuliya]

Attachment: fx-fullscreen.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161104212021

Steps to reproduce:

1. Open Firefox
2. Enable Developer theme
(On Stable/Beta https://addons.mozilla.org/en-US/firefox/addon/devedition-theme-enabler/ is required; on Developer/Nightly it's already there under Add-ons > Appearance)
3. Press F11


Actual results:

Fullscreen window controls are not shown


Expected results:

Minimise/Resore/Close buttons should be present in the upper-right corner. 

The tooltip appears on hover, and the buttons (areas) work, but the visual indicator is missing, aside from a "minus" symbol where the Minimise button should be.
This is a problem with Firefox 50+, screenshot for comparison between v49 and v50 attatched (as seen on Windows 7).

Comment 1

[:Gijs (he/him)]

Works fine with current devedition on Windows 10.

Can you reproduce with an up-to-date version of devedition and a clean profile (the one in the screenshot has add-ons)? ( https://www.mozilla.org/en-US/firefox/channel/desktop/#developer )

I wonder if this is somehow caused by bug 965322.

Comment 2

[:Gijs (he/him)]

Attachment: use !important to force vista/7 controls in fullscreen even on dark themes,

MozReview-Commit-ID: eIleloCNMZ

Comment 3

[:Gijs (he/him)]

Attachment: use vista/7 style controls in fullscreen even on dark lwtheme/devedition

Not sure which of these 2 patches you prefer. Both work.

Comment 4

[Yuliya]

(In reply to :Gijs Kruitbosch from comment #1)
> Works fine with current devedition on Windows 10.
> 
> Can you reproduce with an up-to-date version of devedition and a clean
> profile (the one in the screenshot has add-ons)? (
> https://www.mozilla.org/en-US/firefox/channel/desktop/#developer )
> 
> I wonder if this is somehow caused by bug 965322.

Yes, the issue is present on the latest Nightly (53.0a1 (2016-11-21) (64-bit)) too.

Comment 5

[Yuliya]

Attachment: Nightly 53.0a1 (2016-11-21) (64-bit)

I noticed now that light theme works fine, it's only the dark one. No add-ons on this one (besides the system add-ons it comes with) and a clean profile.

Comment 6

[Yuliya]

Attachment: 53.0a1 (2016-11-21) (64-bit)_light_on_hover.png

Although close button becomes a red square on hover on light one.

Comment 7

[:Gijs (he/him)]

(In reply to Yuliya from comment #6)
> Created attachment 8812851 [details]
> 53.0a1 (2016-11-21) (64-bit)_light_on_hover.png
> 
> Although close button becomes a red square on hover on light one.

This also happens on the default theme. That makes this a more significant problem.

Comment 8

[:Gijs (he/him)]

Attachment: force using vista/7 style controls in fullscreen on those OSes

Comment 9

[:Gijs (he/him)]

Attachment: use !important to force vista/7 controls in fullscreen even on dark themes,

MozReview-Commit-ID: eIleloCNMZ

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f9e1e63b710
use !important to force vista/7 controls in fullscreen even on dark themes, r=dao

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7f9e1e63b710

Comment 12

[:Gijs (he/him)]

Comment on attachment 8813633 [details] [diff] [review]
use !important to force vista/7 controls in fullscreen even on dark themes,

Approval Request Comment
[Feature/regressing bug #]: bug 965322
[User impact if declined]: broken window button styling in fullscreen on Windows 7 and below
[Describe test coverage new/current, TreeHerder]: nope, styling only
[Risks and why]: low-ish, styling only.
[String/UUID change made/needed]: nope

Comment 13

[Gerry Chang [:gchang]]

Hi Brindusa, 
Can you have someone verify if this is fixed on latest nightly? Thanks.

Comment 14

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 6.1; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20161125030214

Verified as fixed using the latest Nightly 53.0a1 on Windows 7 - windows controls in full screen are properly displayed (with or without the dark theme).

Please note that the fix could not be verified on older OS'es than Windows 7 (Xp and Vista) because the latest Nightly can't be installed - "Sorry Nightly can't be installed. This version of Nightly requires Microsoft Windows 7 or newer".

Comment 15

[Gerry Chang [:gchang]]

Comment on attachment 8813633 [details] [diff] [review]
use !important to force vista/7 controls in fullscreen even on dark themes,

Fix a theme issue in windows 7. Beta51+ and Aurora52+. Should be in 51 beta 4.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cf76a8e08edf

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4164d5620eac

Comment 18

[Simona Badau, Desktop QA]

Verified as fixed using the latest Firefox 51.0b4 (Build ID: 20161128075558)and Firefox Developer Edition 53.0a2 (Build ID: 20161129031443) on Windows XP, Windows Vista and Windows 7.