Closed
Bug 1319197
Opened 8 years ago
Closed 8 years ago
Remove audio decoding from gmp-clearkey
Categories
(Core :: Audio/Video: GMP, defect, P3)
Core
Audio/Video: GMP
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: cpearce, Assigned: jay.harris)
Details
Attachments
(1 file)
We should remove the audio decoding code from gmp-clearkey. The Widevine CDM doesn't contain an audio decoder, and one of the key goals of gmp-clearkey is to provide test coverage for the things that Widevine does, so we should ensure we're testing the audio decryption (rather than decoding) code path in gmp-clearkey on Windows. We'll also be removing audio decode capability when we port gmp-clearkey to use the Chromium CDM API. So we may as well remove it before we start.
Comment hidden (mozreview-request) |
Reporter | ||
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8813464 [details] Bug 1319197 - Remove audio decoding from gmp-clearkey https://reviewboard.mozilla.org/r/94872/#review95088 ::: media/gmp-clearkey/0.1/gmp-clearkey.cpp:65 (Diff revision 1) > #if defined(ENABLE_WMF) > - else if (!strcmp(aApiName, GMP_API_AUDIO_DECODER) && > + else if (!strcmp(aApiName, GMP_API_VIDEO_DECODER) && > - wmf::EnsureLibs()) { > - *aPluginAPI = new AudioDecoder(static_cast<GMPAudioHost*>(aHostAPI)); > - } else if (!strcmp(aApiName, GMP_API_VIDEO_DECODER) && > wmf::EnsureLibs()) { You also should change wmf::EnsureLibs() to not check for the AAC decoder DLL/module, and WMFDecoderDllNameFor() too. That's in media/gmp-clearkey/0.1/WMFUtils.cpp.
Attachment #8813464 -
Flags: review?(cpearce) → review-
Comment hidden (mozreview-request) |
Reporter | ||
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8813464 [details] Bug 1319197 - Remove audio decoding from gmp-clearkey https://reviewboard.mozilla.org/r/94872/#review95092 ::: media/gmp-clearkey/0.1/WMFUtils.cpp:72 (Diff revision 2) > } > return sInitOk; > } > > const char* > WMFDecoderDllNameFor(CodecType aCodec) WMFDecoderDllNameFor only works for H.264, so we may as well rename it to WMFH264DecoderDllName, and remove the CodecType enum as well.
Attachment #8813464 -
Flags: review?(cpearce) → review-
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•8 years ago
|
||
TreeHerder Build for the current commit: https://treeherder.mozilla.org/#/jobs?repo=try&revision=17fb7d578300842a2d78ce92e173861f2f299996
Comment hidden (mozreview-request) |
Reporter | ||
Comment 8•8 years ago
|
||
Comment on attachment 8813464 [details] Bug 1319197 - Remove audio decoding from gmp-clearkey r+. For some reason I can't mark this as review-granted inside reviewboard; I keep getting 500 errors.
Attachment #8813464 -
Flags: review?(cpearce) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ee43b0af2a45 Remove audio decoding from gmp-clearkey. r=cpearce
Keywords: checkin-needed
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ee43b0af2a45
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•