1319670 - firefox/sync template contains instructions for obsolete versions of Firefox

Status: NEW

(www.mozilla.org :: Pages & Content, defect)

Description

[Friedel Wolff]

I can't see the this string from /firefox/sync.lang on the web:
Click “<strong>Get started</strong>” in the tab that opens.
and I also can't see something to click with the text "Get started" in the tab that opens in the Firefox preferences. It seems as if the string is not needed and possibly also incorrect?

I'm guessing this string I kept untranslated is the reason why my translation is not being deployed.

Comment 1

[Francesco Lodolo [:flod]]

There are a few cases where this is going to happen, and there's not much we can do about it.

First example (most common):
* When a new page is created, it has 30 strings.
* After a while, a few strings are added, and we use a system called l10n tags: if the locale has these new strings, we add a tag and start displaying the new text. At the same time, we need to keep the old strings around, because they're used by some other locales.

The result is that we can avoid displaying English text on other languages while they translate new strings, the bad part is that new locales starting (or behind) will be exposed to both strings. There's no way to manually check that, since we're talking about thousands of files.

In this case, the string was used for older versions of Firefox, but it's still in the template. Until the template is cleaned up, we'll keep those strings around.
https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templates/firefox/sync.html#L103-L128

Comment 2

[Friedel Wolff]

Thanks, Francesco. Do I understand correctly that I just have to provide "some" translation so that my translated file can be deployed?

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Friedel Wolff from comment #2)
> Thanks, Francesco. Do I understand correctly that I just have to provide
> "some" translation so that my translated file can be deployed?

Yes, you could even copy the original text, but I would still try to provide a reasonable one though ;-)

Comment 4

[Alex Gibson [:agibson]]

We have logic in this page that shows different Sync instructions depending on the version of a Firefox a user is on, so the strings in the template are still "in use" technically. We could probably drop some of the conditional states here now, as there can't be many users still on Firefox 28 or below. I doubt this will happen until the next time we revisit this page however (at which point we can hopefully remove some of the over-complex logic).