Closed
Bug 1320317
Opened 8 years ago
Closed 8 years ago
Use :-moz-focusring instead of :focus in notification.css
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | unaffected |
| firefox51 | --- | unaffected |
| firefox52 | --- | unaffected |
| firefox53 | --- | fixed |
People
(Reporter: dao, Assigned: joshihamel, Mentored)
References
Details
(Keywords: good-first-bug, regression, Whiteboard: [good first bug][lang=css])
Attachments
(1 file)
|
1.47 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
:-moz-focusring follows platform conventions for when to draw a focus ring; :focus doesn't. Affected files: toolkit/themes/linux/global/notification.css toolkit/themes/osx/global/notification.css toolkit/themes/windows/global/notification.css
|
Reporter | |
Updated•8 years ago
|
Keywords: regression
|
Assignee | |
Comment 1•8 years ago
|
||
Hi Dão, I would like to work on this bug item. Is this just a simple change of :focus to :-moz-focusring in the various files? Thanks
|
|
Reporter | |
Comment 2•8 years ago
|
||
(In reply to Hamel Joshi from comment #1) > Hi Dão, > > I would like to work on this bug item. Is this just a simple change of > :focus to :-moz-focusring in the various files? Yep, that's it.
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8814488 -
Flags: review?(dao+bmo)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Hi Dão, I have attached a patch for this bug so that it can be reviewed. Thanks
|
|
Reporter | |
Comment 5•8 years ago
|
||
Comment on attachment 8814488 [details] [diff] [review] Bug 1320317 - Changed :focus to :-moz-focusring in notification.css files. Looks good, thanks!
Attachment #8814488 -
Flags: review?(dao+bmo) → review+
|
|
Reporter | |
Updated•8 years ago
|
Assignee: nobody → joshihamel
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5f7557f3e492 Use :-moz-focusring instead of :focus in notification.css. r=dao
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5f7557f3e492
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•7 years ago
|
status-firefox50:
--- → unaffected
status-firefox51:
--- → unaffected
status-firefox52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•