1320710 - Target i686-unknown-linux-gnu when building rust code for linux32

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

Now that we'd dropped support for linux32 machines without SSE2 support, switch back to the default i686 rust target.

This lets rust code generation take advantage of SSE2 instructions, and simplifies installing dependencies by using use the default stable target for this platform.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1320710 - Target i686 rust code on linux32.

Official Mozilla builds no longer support non-SSE2 x86 cpus,
so we can use the default i686 rust target here. This allows
better code generation and removes a dependency on the extra
i585 rust std library.

Review commit: https://reviewboard.mozilla.org/r/96012/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96012/

Comment 2

[Ralph Giles (:rillian)]

Oops, need to update the tooltool manifest too.

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8814964 [details]
Bug 1320710 - Target i686 rust code on linux32.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96012/diff/1-2/

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8814964 [details]
Bug 1320710 - Target i686 rust code on linux32.

https://reviewboard.mozilla.org/r/96012/#review97412

::: browser/config/tooltool-manifests/linux32/releng.manifest:20
(Diff revision 2)
> -"size": 96275316,
> -"digest": "26c11e34df81f5d7ffafc3492df9c6821f644a2e2eda5cfbbcdb1ac23e4ee196007b417c862c60a97bbf66e4be9c801400990938cd3aefec19b1cf9eaf1a9b54",
> +"size": 94830820,
> +"digest": "6f2a1cf325d957f0328d2d853fc07944a857e872f6e44df15f6ebb45c032c0ebbf52f56c872bc72927ebcdd830002d759dd92e8fc90048b52c07058955c69c4c",

How was this generated?

Comment 5

[Ralph Giles (:rillian)]

In https://github.com/rillian/rust-build/

1. repack_rust.py to repackage the upstream builds.
2. manual tooltool add and upload.
3. splat_rust.py to update gecko manifests.

I'll file a bug to update the in-tree versions. I'd like to make taskcluster do all this, but haven't take the time to learn the new dispatch stuff. Do you have the clang builds updating tooltool or another example I could read?

Comment 6

[Ralph Giles (:rillian)]

(In reply to Ralph Giles (:rillian) needinfo me from comment #5)

> I'll file a bug to update the in-tree versions.

This has now landed in bug 1321863.

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8814964 [details]
Bug 1320710 - Target i686 rust code on linux32.

https://reviewboard.mozilla.org/r/96012/#review97412

> How was this generated?

In https://github.com/rillian/rust-build/

1. repack_rust.py to repackage the upstream builds.
2. manual tooltool add and upload.
3. splat_rust.py to update gecko manifests.

I updated the in-tree copy of the scripts in https://bugzilla.mozilla.org/show_bug.cgi?id=1321863

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 8814964 [details]
Bug 1320710 - Target i686 rust code on linux32.

https://reviewboard.mozilla.org/r/96012/#review98356

Comment 9

[Nathan Froyd [:froydnj]]

Comment on attachment 8814964 [details]
Bug 1320710 - Target i686 rust code on linux32.

Canceling ted's review.

Comment 10

[Nathan Froyd [:froydnj]]

(In reply to Ralph Giles (:rillian) needinfo me from comment #5)
> I'll file a bug to update the in-tree versions. I'd like to make taskcluster
> do all this, but haven't take the time to learn the new dispatch stuff. Do
> you have the clang builds updating tooltool or another example I could read?

Make taskcluster do this in what sense?  It should not be hard to add a taskcluster toolchain task to do all the repacking...not sure about the updating of the manifests, though.  Bug 1313111 tracks something more ambitious, but I don't think we'd be able to ditch tooltool.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d14d37c2c99
Target i686 rust code on linux32. r=froydnj

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2d14d37c2c99

Comment 13

[Ralph Giles (:rillian)]

(In reply to Nathan Froyd [:froydnj] from comment #10)

> Make taskcluster do this in what sense?

I don't have a specific plan. I just wanted to express general intent to continue improving the automation for this.

I think there's a way to access published artifacts from a depending task in taskcluster builds, so it would be nice to hook that up. While we're still running buildbot jobs we'll need to update the tooltool manifests. A task could build and upload packages, then generate the patch, but it would be need to land through normal channels, with a bug created manually or with some not-currently-existing automation access.