Closed
Bug 1320880
Opened 8 years ago
Closed 7 years ago
[DateTimePicker] Add RTL support to date picker
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: scottwu, Assigned: scottwu)
References
(Blocks 1 open bug)
Details
(Keywords: rtl)
Attachments
(1 file)
Date picker's layout should display properly under RTL locales.
|
||
Comment 1•8 years ago
|
||
I wrote a patch that will expose an API to get directionality from mozIntl: bug 1312053. Simple API so should land soon hopefully.
|
Assignee | |
Comment 2•8 years ago
|
||
That's great! I was wondering how to get locale direction so this would definitely help.
|
||
Updated•7 years ago
|
Blocks: datetime-bugs
|
|
||
Updated•7 years ago
|
No longer blocks: datetime-bugs
|
||
Updated•7 years ago
|
Component: XUL Widgets → Layout: Form Controls
Product: Toolkit → Core
Version: unspecified → 53 Branch
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → scwwu
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8838467 -
Flags: review?(mconley)
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8838467 [details] Bug 1320880 - Add RTL support to date picker https://reviewboard.mozilla.org/r/113404/#review118350 Looks okay to me! (I didn't test this though). Thanks scottwu!
Attachment #8838467 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Comment 6•7 years ago
|
||
The layout looks fine to me when I tested with `ar` and `fa-IR`, though I hope to get more feedback from people who actually uses RTL locales once this lands. Thank you Mike!
Keywords: checkin-needed
|
||
Comment 7•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s d5ff982063e2 -d 3436c6cf4123: rebasing 379410:d5ff982063e2 "Bug 1320880 - Add RTL support to date picker r=mconley" (tip) merging toolkit/content/widgets/datetimepopup.xml warning: conflicts while merging toolkit/content/widgets/datetimepopup.xml! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
|
||
Updated•7 years ago
|
Keywords: checkin-needed
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ee721adb0e10 Add RTL support to date picker r=mconley
Keywords: checkin-needed
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ee721adb0e10
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•