1320889 - Tapping the notification for a downloaded file from outside of firefox opens firefox and then the file.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Kaartic Sivaraam]

When a notification of a downloaded file is tapped from outside of firefox (e.g) from the home screen, the browser opens up and only then is the file opened. I guess this shouldn't happen, because the user only intends to open the file and not firefox. This also causes some delay in mobile that are a bit slow.

Steps to reproduce:
1. Download something in firefox 
(this image for example http://media-cache-ec0.pinimg.com/736x/66/8a/7f/668a7fdb6463c5bec32f4f405cac3b2d.jpg)

2. Go to the home screen.
3. Tap the download notification in the notification bar

Expected results:
The file opens up

Actual results:
Firefox is opened first and then the file opens up

Comment 1

[Jan Henning [:JanH]]

Just guessing, but this might have a similar background as bug 1075476.

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Attachment: bugbug1320889.mp4

Thanks for reporting.
But I can't reproduce it in the latest version of Android app.
Could you please help verify again for me?
Thank you!

Comment 3

[Kaartic Sivaraam]

I could see Firefox in the background when you tapped the notification of the downloaded file in the video. 

I guess you are mis-understanding the problem. The problem is that when the notification of a downloaded file is tapped from outside of Firefox (e.g. from the home screen) it brings Firefox to the foreground  and then shows options to open the file. This should not be the case, and it is not the case with other browsers (atleast with the ones I use). Try the above steps with another browser such as Chrome and compare the results (you probably shouldn't be seeing the other browsers in the background after you tap the notification of the downloaded file).

Anyways I am using Firefox 52.0a2 currently and could reproduce the issue reported here. Ask me if the above explanation wasn't clear :).

Comment 4

[Nevin Chen(Not active on Bugzilla)]

(In reply to Kaartic Sivaraam from comment #3)
> Anyways I am using Firefox 52.0a2 currently and could reproduce the issue
> reported here. Ask me if the above explanation wasn't clear :).

Oh.. Thanks a lot for the clarification. I got your point now. The browser shouldn't even appear!
I'll try to fix it later.

Comment 5

[Nevin Chen(Not active on Bugzilla)]

I found some related code change/ bug related to this issue in bug 950417 1268455 1276696.
The comment/history is quite large/long. I'll check this later.

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1320889 - Tapping the notification for a downloaded file shouldn't open firefox.

Review commit: https://reviewboard.mozilla.org/r/99078/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99078/

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Ahunt, can you take this review? I've too much in my list currently. :)

Comment 8

[Andrzej Hunt :ahunt]

Comment on attachment 8819227 [details]
Bug 1320889 - Tapping the notification for a downloaded file shouldn't open firefox.

https://reviewboard.mozilla.org/r/99078/#review99480

::: mobile/android/base/java/org/mozilla/gecko/notifications/NotificationHelper.java:313
(Diff revision 1)
>          }
>  
> +        // Bug 1320889 - Tapping the notification for a downloaded file shouldn't open firefox.
> +        // If the gecko event is for download completion, we create another intent with different
> +        // scheme to prevent Fennec from popping up.
> +        Intent viewFileIntent = createIntentIfDownloadCompleted(message);

nit: final

Comment 9

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8819227 [details]
Bug 1320889 - Tapping the notification for a downloaded file shouldn't open firefox.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99078/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a06f80881726
Tapping the notification for a downloaded file shouldn't open firefox. r=ahunt

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a06f80881726

Comment 12

[Kaartic Sivaraam]

Should this be fixed in Firefox Aurora by now ? I am using the version downloaded on 02-01-2017, as of writing.

Comment 13

[Jan Henning [:JanH]]

Nope, it's fixed only fixed starting from Firefox 53, which will become the version on Aurora in about two weeks.

Comment 14

[Carmen Fat [:cfat] - Ecosystem QA]

Tested on latest Aurora build 53.0a2 (2017-02-23) using LG G4 (Android 5.1).
After sending Fennec into background and tapping the download notification, the browser is not displayed in the foreground.

Marking this as Verified for Firefox 53.