1320916 - Differences in the commit tables between environments

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

It looks like an index on `revision` was manually added to prod, but not reflected in the model. 

Will, should we:
(a) add it to the model too
(b) drop the index on prod

I'm fine with deprecating searching by commit revision fwiw (and only allowing searching by push revision).

--- vagrant.sql	2016-11-25 17:22:53.439965200 +0000
+++ prod.sql	2016-11-25 17:31:49.775087600 +0000
...
 --
 -- Table structure for table `commit`
 --
 
 DROP TABLE IF EXISTS `commit`;
 /*!40101 SET @saved_cs_client     = @@character_set_client */;
 /*!40101 SET character_set_client = utf8 */;
 CREATE TABLE `commit` (
   `id` int(11) NOT NULL AUTO_INCREMENT,
   `revision` varchar(40) COLLATE utf8_bin NOT NULL,
   `author` varchar(150) COLLATE utf8_bin NOT NULL,
   `comments` longtext COLLATE utf8_bin NOT NULL,
   `push_id` int(11) NOT NULL,
   PRIMARY KEY (`id`),
   UNIQUE KEY `<INDEX_NAME>` (`push_id`,`revision`),
   KEY `<INDEX_NAME>` (`push_id`),
+  KEY `<INDEX_NAME>` (`revision`),
   CONSTRAINT `<INDEX_NAME>` FOREIGN KEY (`push_id`) REFERENCES `push` (`id`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin;
 /*!40101 SET character_set_client = @saved_cs_client */;

Comment 1

[William Lachance (:wlach)]

Yeah that index wasn't doing us any good (queries didn't wind up using it), so I dropped it.

Let's just leave things for be for now, since there don't seem to be any major problems.

Comment 2

[Ed Morley [:emorley]]

Many thanks :-)