Closed
Bug 1321008
Opened 8 years ago
Closed 7 years ago
Add telemetry to AS context menu for add/remove bookmark
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox53 fixed)
RESOLVED
FIXED
Firefox 53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: sebastian, Assigned: ahunt)
References
Details
(Whiteboard: [MobileAS])
Attachments
(1 file)
No description provided.
Reporter | ||
Updated•8 years ago
|
Priority: -- → P2
Whiteboard: [MobileAS]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ahunt
Iteration: --- → 1.10
Priority: P2 → P1
Comment hidden (mozreview-request) |
Reporter | ||
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8815834 [details] Bug 1321008 - Add telemetry for AS context menu bookmark/unbookmark https://reviewboard.mozilla.org/r/96616/#review97988 ::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/menu/ActivityStreamContextMenu.java:177 (Diff revision 1) > + telemetryEvent = TelemetryContract.Event.SAVE; > + telemetryExtra = "as_bookmark"; Shouldn't we here also check whether it's a reader mode url and send a different telemetry probe so that the telemetry for save/unsave is somewhat synchronous?
Attachment #8815834 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8815834 [details] Bug 1321008 - Add telemetry for AS context menu bookmark/unbookmark https://reviewboard.mozilla.org/r/96616/#review98394 ::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/menu/ActivityStreamContextMenu.java:177 (Diff revision 1) > + telemetryEvent = TelemetryContract.Event.SAVE; > + telemetryExtra = "as_bookmark"; I don't think that's possible in this case - any pages showing in activity stream won't be reader view URLs (i.e. we remove about:reader? before storing in history, so AS won't know that it originally was an about:reader page).
Pushed by ahunt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e573f18c8dc7 Add telemetry for AS context menu bookmark/unbookmark r=sebastian
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e573f18c8dc7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Updated•7 years ago
|
Blocks: as-android-telemetry
Updated•7 years ago
|
Iteration: 1.10 → 1.11
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•