1321418 - Convert GeckoApp/BrowserApp events to bundle events

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Make GeckoApp/BrowserApp events use BundleEventListener/GeckoBundle

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 1. Use GekcoBundle events in GeckoApp (v1)

Switch GeckoApp to using GeckoBundle events everywhere. UI or Gecko
events are used if the event requires the UI or Gecko thread,
respectively, and background events are used for all other events.

There are changes to some other Java classes, such as SnackbarBuilder
and GeckoAccessibility, due to the switch to GeckoBundle.

For "Snackbar:Show", we need the global EventDispatcher because the
event can be sent to both GeckoApp and GeckoPreferences. Howveer, we
only want one listener registered at the same time, so we register and
unregister in GeckoApp's and GeckoPreferences's onPause and onResume
methods.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 2. Use appropriate JS EventDispatcher to send GeckoApp events (v1)

Change JS code that sends events to GeckoApp to use either the global
EventDispatcher or the per-window EventDispatcher.

"Session:StatePurged" is not used so it's removed. "Gecko:Ready" in
geckoview.js is not necessary because it's only used for GeckoApp, so
it's removed from geckoview.js.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 3. Use GeckoBundle events in BrowserApp (v1)

Switch BrowserApp to using GeckoBundle events, in a similar vein as
GeckoApp. UI or Gecko events are used if the event handlers required UI
or Gecko thread, respectively, and background events are used for all
other events.

Some other Java classes also have to be modified as a result of
switching to GeckoBundle.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 4. Use global EventDispatcher to send BrowserApp events (v1)

Change JS code that sends events to BrowserApp to use the global
EventDispatcher instead of "Messaging".

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 5. Update usages of events in tests (v1)

Update cases where we use or wait for events in tests.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8816524 [details] [diff] [review]
3. Use GeckoBundle events in BrowserApp (v1)

Review of attachment 8816524 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with a fix for the thing mentioned below.

::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ +2007,2 @@
>                  final String location = message.getString("location");
> +                final boolean hasImage = message.getBoolean("hasImage");

This is a wrong refactoring: There's no field "hasImage". Instead the value is determined by whether the "image_url" field is set or not.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Sebastian Kaspari (:sebastian) from comment #6)
> Comment on attachment 8816524 [details] [diff] [review]
> 3. Use GeckoBundle events in BrowserApp (v1)
> 
> Review of attachment 8816524 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This is a wrong refactoring: There's no field "hasImage". Instead the value
> is determined by whether the "image_url" field is set or not.

I added "hasImage" in part 4 :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cce3b69bfc7
Use GekcoBundle events in GeckoApp/BrowserApp; r=snorp r=sebastian r=gbrown

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1cce3b69bfc7

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Update menu items using the correct ID (v1)

Regression caused by an incorrect ID used to update menu items.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/84abf2ef2fab
Update menu items using the correct ID; r=sebastian

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/84abf2ef2fab