1321480 - Firefox Puppeteer has to use Marionette's "page load" timeout

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Right now we define our own value for the page load timeout:

https://hg.mozilla.org/mozilla-central/file/324855/testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/browser/window.py#l48

It's been in use in a couple of firefox-ui tests under testing/firefox-ui/tests. 

We should change that so we make use of self.marionette.timeout.page_load instead. It also means that this specific property from above can be removed.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Adrian, are you interested to pick up this bug as your first one?

Comment 2

[Adrian Zatreanu]

Sure thing! :)

Comment 3

[Adrian Zatreanu]

Attachment: Bug 1321480: Make Firefox Puppeteer use Marionette's "page load" timeout

This is being used instead of a self-defined Browser.timeout.

Review commit: https://reviewboard.mozilla.org/r/96894/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96894/

Comment 4

[Adrian Zatreanu]

Comment on attachment 8816094 [details]
Bug 1321480: Make Firefox Puppeteer use Marionette's "page load" timeout

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96894/diff/1-2/

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8816094 [details]
Bug 1321480: Make Firefox Puppeteer use Marionette's "page load" timeout

https://reviewboard.mozilla.org/r/96894/#review97154

The patch looks great and updates all the instances we currently have for that timeout property. The try build was also fine, so I'm going to push this patch in a bit to autoland.

Thanks a lot for your work! It's great to see that you were able to get all of this done with any further help.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8816094 [details]
Bug 1321480: Make Firefox Puppeteer use Marionette's "page load" timeout

https://reviewboard.mozilla.org/r/96894/#review97156

Oh, would you mind to please update the commit message so it sounds what the bug summary says? Once done I will push it. Thanks.

Comment 7

[Adrian Zatreanu]

Comment on attachment 8816094 [details]
Bug 1321480: Make Firefox Puppeteer use Marionette's "page load" timeout

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96894/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3d8baec7db0
Make Firefox Puppeteer use Marionette's "page load" timeout r=whimboo

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a3d8baec7db0

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Test-only change which will make our tests more stable for remote page loads. Please uplift to aurora. Thanks.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/988ab8a46590